Unify and Improve the Sign-In and Sync Confirmation Screens on Clank.

chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
index 5f2749c02211638b11ec085e4294246f3c50e889..aef27ba637ffdfa2a350b463184e1405baf9aebc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
@@ -5,7 +5,9 @@
 package org.chromium.chrome.browser.ntp;
 
 import android.content.Context;
+import android.content.SharedPreferences;
 import android.graphics.Bitmap;
+import android.preference.PreferenceManager;
 
 import org.chromium.base.ObserverList;
 import org.chromium.base.ThreadUtils;
@@ -51,6 +53,8 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
     }
 
     private static final int RECENTLY_CLOSED_MAX_TAB_COUNT = 5;
+    private static final String PREF_SIGNIN_PROMO_DECLINED =
+            "recent_tabs_signin_promo_declined";
 
     private final Profile mProfile;
     private final Tab mTab;
@@ -385,10 +389,25 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
             return false;
         }
 
+        if (PreferenceManager.getDefaultSharedPreferences(mContext).getBoolean(

[newt (away), 2016/02/09 23:08:12]

Please document this change in behavior in the CL description.

[PEConn, 2016/02/11 14:44:55]

Done.

+                PREF_SIGNIN_PROMO_DECLINED, false)) {
+            return false;
+        }
+
         return !AndroidSyncSettings.isSyncEnabled(mContext) || mForeignSessions.isEmpty();
     }
 
     /**
+     * Save that user tapped "No" button on the signin promo.
+     */
+    public void setSigninPromoDeclined() {
+        SharedPreferences.Editor sharedPreferencesEditor =
+                PreferenceManager.getDefaultSharedPreferences(mContext).edit();
+        sharedPreferencesEditor.putBoolean(PREF_SIGNIN_PROMO_DECLINED, true);
+        sharedPreferencesEditor.apply();
+    }
+
+    /**
      * Collapse the sync promo.
      *
      * @param isCollapsed Whether the sync promo is collapsed.