chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java - Issue 1574273002: Unify and Improve the Sign-In and Sync Confirmation Screens on Clank.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java

Issue 1574273002: Unify and Improve the Sign-In and Sync Confirmation Screens on Clank. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/firstrun/ImageCarousel.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/ImageCarousel.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java

index 21b87a80ee2645a7d7a209f346cda70d04c70773..25b590b8859b23fcf7c4784456efcb8afb08eee1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java

@@ -142,7 +142,7 @@ public class ProfileDataCache implements Observer {

Bitmap bitmap) {

bitmap = getCroppedBitmap(bitmap);

mCacheEntries.put(accountId, new CacheEntry(bitmap, fullName, givenName));

- if (mObserver != null) mObserver.onProfileDownloaded(accountId, givenName, fullName,

+ if (mObserver != null) mObserver.onProfileDownloaded(accountId, fullName, givenName,

newt (away) 2016/02/09 23:08:12 It looks like you're fixing a bug along with the r

PEConn 2016/02/11 14:44:55 Done.

bitmap);

}