Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 157423002: Rename MediaControlsChromiumAndroid to MediaControlsAndroid (Closed)

Created:
6 years, 10 months ago by philipj_slow
Modified:
6 years, 10 months ago
CC:
blink-reviews, nessy, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Rename MediaControlsChromiumAndroid to MediaControlsAndroid BUG=341813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166901

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -154 lines) Patch
M Source/core/core.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/html/shadow/MediaControlsAndroid.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A + Source/core/html/shadow/MediaControlsAndroid.cpp View 1 3 chunks +7 lines, -7 lines 0 comments Download
D Source/core/html/shadow/MediaControlsChromiumAndroid.h View 1 2 1 chunk +0 lines, -53 lines 0 comments Download
D Source/core/html/shadow/MediaControlsChromiumAndroid.cpp View 1 1 chunk +0 lines, -86 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
philipj_slow
Patch 2, depends on https://codereview.chromium.org/157403002/ https://codereview.chromium.org/130693008/ is all of the patches together in a trybot ...
6 years, 10 months ago (2014-02-07 13:28:11 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 10 months ago (2014-02-07 21:59:55 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-08 05:53:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/157423002/1
6 years, 10 months ago (2014-02-08 05:53:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-08 07:10:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=26451
6 years, 10 months ago (2014-02-08 07:10:45 UTC) #6
philipj_slow
rebased to depend on https://codereview.chromium.org/158333002/
6 years, 10 months ago (2014-02-08 18:43:47 UTC) #7
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-11 05:58:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/157423002/340001
6 years, 10 months ago (2014-02-11 05:58:56 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 06:54:52 UTC) #10
Message was sent while issue was closed. 
Change committed as 166901

Powered by Google App Engine
This is Rietveld 408576698