Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1574213006: DevTools: beautified styles sidebar toolbar. (Closed)

Created:
4 years, 11 months ago by pfeldman
Modified:
4 years, 11 months ago
Reviewers:
dgozman, sergeyv
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: beautified styles sidebar toolbar. NOTRY=true Committed: https://crrev.com/c2ed5bb3ec005ef4afff4465d8e1d24e03e9ca59 Cr-Commit-Position: refs/heads/master@{#369919}

Patch Set 1 #

Patch Set 2 : rebaselined #

Total comments: 5

Patch Set 3 : review comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -78 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementStatePaneWidget.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsTreeOutline.css View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/FontView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/ImageView.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 1 2 9 chunks +62 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/infobar.css View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 2 3 chunks +8 lines, -4 lines 0 comments Download

Dependent Patchsets:

Issue 1599603002 Patch 40001

Messages

Total messages: 16 (9 generated)
pfeldman
4 years, 11 months ago (2016-01-13 22:37:18 UTC) #2
pfeldman
PTAL
4 years, 11 months ago (2016-01-14 21:25:08 UTC) #3
dgozman
lgtm https://codereview.chromium.org/1574213006/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/ElementStatePaneWidget.js File third_party/WebKit/Source/devtools/front_end/elements/ElementStatePaneWidget.js (left): https://codereview.chromium.org/1574213006/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/ElementStatePaneWidget.js#oldcode127 third_party/WebKit/Source/devtools/front_end/elements/ElementStatePaneWidget.js:127: this._button = new WebInspector.ToolbarToggle(WebInspector.UIString("Toggle Element State"), "pin-toolbar-item"); Kill ...
4 years, 11 months ago (2016-01-14 22:05:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574213006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574213006/40001
4 years, 11 months ago (2016-01-16 00:15:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1574213006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1574213006/40001
4 years, 11 months ago (2016-01-16 01:56:59 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-16 02:04:25 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-16 02:05:19 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c2ed5bb3ec005ef4afff4465d8e1d24e03e9ca59
Cr-Commit-Position: refs/heads/master@{#369919}

Powered by Google App Engine
This is Rietveld 408576698