third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js - Issue 1574213006: DevTools: beautified styles sidebar toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js

Issue 1574213006: DevTools: beautified styles sidebar toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/module.json ('k') | third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js

index 4f9f86df41088e75dffe774c955e82012050ea1a..66884aa469a8b911f2c66bf81b9dde15b0caa515 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js

@@ -349,7 +349,7 @@ WebInspector.DeviceModeView.Toolbar = function(model, showMediaInspectorSetting,

this._lastMode = new Map();

/** @type {?WebInspector.EmulatedDevice} */

this._lastDevice = null;

- /** @type {!Array<!WebInspector.ToolbarLabel>} */

+ /** @type {!Array<!WebInspector.ToolbarButton>} */

this._appliedSizeItems = [];

/** @type {!Array<!WebInspector.ToolbarMenuButton>} */

this._scaleItems = [];

@@ -380,11 +380,11 @@ WebInspector.DeviceModeView.Toolbar = function(model, showMediaInspectorSetting,

rightContainer.createChild("div", "device-mode-toolbar-spacer");

var rightToolbar = new WebInspector.Toolbar("", rightContainer);

rightToolbar.makeWrappable(true);

- this._uaItem = new WebInspector.ToolbarLabel();

+ this._uaItem = new WebInspector.ToolbarText();

this._uaItem.setVisible(false);

this._uaItem.setTitle(WebInspector.UIString("User agent type"));

rightToolbar.appendToolbarItem(this._uaItem);

- this._deviceScaleItem = new WebInspector.ToolbarLabel();

+ this._deviceScaleItem = new WebInspector.ToolbarText();

this._deviceScaleItem.setVisible(false);

this._deviceScaleItem.setTitle(WebInspector.UIString("Device pixel ratio"));

rightToolbar.appendToolbarItem(this._deviceScaleItem);

@@ -562,7 +562,7 @@ WebInspector.DeviceModeView.Toolbar.prototype = {

_appendAppliedSizeItems: function(toolbar)

{

- var item = new WebInspector.ToolbarLabel();

+ var item = new WebInspector.ToolbarText("");

this._appliedSizeItems.push(item);

toolbar.appendToolbarItem(item);

@@ -575,7 +575,6 @@ WebInspector.DeviceModeView.Toolbar.prototype = {

var scaleItem = new WebInspector.ToolbarMenuButton(this._appendScaleMenuItems.bind(this));

scaleItem.setTitle(WebInspector.UIString("Zoom"));

scaleItem.setGlyph("");

- scaleItem.setBold(false);

scaleItem.addDropDownArrow();

toolbar.appendToolbarItem(scaleItem);

this._scaleItems.push(scaleItem);