Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Issue 1574005: VBoot Reference: Refactor Part 2 - Crypto Libraries (Closed)

Created:
10 years, 8 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, gauravsh
Visibility:
Public.

Description

VBoot Reference: Refactor Part 2 - Crypto Libraries Removing multiple top level includes - now padding.h, rsa.h and sha.h are used internally and cryptolib.h must be used instead for all modules that wish to use crypto functions. I am trying to separate refactors involving code movement from one file to another, and the movement of files themselves into separate CLs so that it's clear what changed.

Patch Set 1 : . #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -255 lines) Patch
M src/platform/vboot_reference/crypto/genpadding.sh View 1 chunk +12 lines, -0 lines 0 comments Download
M src/platform/vboot_reference/crypto/padding.c View 3 chunks +16 lines, -4 lines 0 comments Download
M src/platform/vboot_reference/crypto/rsa.c View 4 chunks +6 lines, -9 lines 0 comments Download
M src/platform/vboot_reference/crypto/rsa_utility.c View 1 chunk +2 lines, -4 lines 0 comments Download
M src/platform/vboot_reference/crypto/sha1.c View 2 chunks +6 lines, -5 lines 0 comments Download
M src/platform/vboot_reference/crypto/sha2.c View 5 chunks +6 lines, -6 lines 0 comments Download
M src/platform/vboot_reference/crypto/sha_utility.c View 2 chunks +2 lines, -48 lines 0 comments Download
A src/platform/vboot_reference/include/cryptolib.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/platform/vboot_reference/include/file_keys.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/platform/vboot_reference/include/firmware_image_fw.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform/vboot_reference/include/kernel_image_fw.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/platform/vboot_reference/include/padding.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/platform/vboot_reference/include/rsa.h View 2 chunks +59 lines, -5 lines 0 comments Download
D src/platform/vboot_reference/include/rsa_utility.h View 1 chunk +0 lines, -58 lines 0 comments Download
M src/platform/vboot_reference/include/sha.h View 2 chunks +46 lines, -2 lines 0 comments Download
D src/platform/vboot_reference/include/sha_utility.h View 1 chunk +0 lines, -53 lines 0 comments Download
M src/platform/vboot_reference/tests/big_firmware_tests.c View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/tests/big_kernel_tests.c View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/tests/firmware_image_tests.c View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/tests/firmware_rollback_tests.c View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/tests/firmware_splicing_tests.c View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform/vboot_reference/tests/firmware_verify_benchmark.c View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform/vboot_reference/tests/kernel_image_tests.c View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/tests/kernel_rollback_tests.c View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/tests/kernel_splicing_tests.c View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform/vboot_reference/tests/kernel_verify_benchmark.c View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform/vboot_reference/tests/rollback_index_mock.c View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/tests/rsa_padding_test.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/platform/vboot_reference/tests/rsa_padding_test.c View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/tests/rsa_verify_benchmark.c View 1 chunk +1 line, -3 lines 0 comments Download
M src/platform/vboot_reference/tests/sha_benchmark.c View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/tests/sha_tests.c View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform/vboot_reference/tests/test_common.c View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/utils/file_keys.c View 2 chunks +22 lines, -2 lines 0 comments Download
M src/platform/vboot_reference/utils/firmware_image.c View 1 chunk +2 lines, -5 lines 0 comments Download
M src/platform/vboot_reference/utils/firmware_image_fw.c View 1 chunk +1 line, -3 lines 0 comments Download
M src/platform/vboot_reference/utils/firmware_utility.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/platform/vboot_reference/utils/kernel_image.c View 1 chunk +1 line, -3 lines 0 comments Download
M src/platform/vboot_reference/utils/kernel_image_fw.c View 1 chunk +1 line, -3 lines 0 comments Download
M src/platform/vboot_reference/utils/kernel_utility.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/platform/vboot_reference/utils/signature_digest.c View 1 chunk +1 line, -3 lines 0 comments Download
M src/platform/vboot_reference/utils/verify_data.c View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gauravsh
10 years, 8 months ago (2010-03-31 02:03:19 UTC) #1
Randall Spangler
10 years, 8 months ago (2010-03-31 04:25:21 UTC) #2
lgtm with one comment

http://codereview.chromium.org/1574005/diff/8001/9028
File src/platform/vboot_reference/tests/rsa_padding_test.h (right):

http://codereview.chromium.org/1574005/diff/8001/9028#newcode15
src/platform/vboot_reference/tests/rsa_padding_test.h:15: #include <stdint.h>
This is transitively included by cryptolib; most other files in this dir don't
seem to include it directly.

Powered by Google App Engine
This is Rietveld 408576698