Issue 15740007: Add for-of Crankshaft support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15740007: Add for-of Crankshaft support

Created:
7 years, 7 months ago by wingo

Modified:
7 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add for-of Crankshaft support This commit adds crankshaft support for for-of. It can be disabled with --nooptimize-for-of. Of course for-of is only enabled with --harmony-iteration. I had moved around the loop bailout ID in the full-codegen to be more like "while" loops. I also had to give positions for the keyed calls and property loads. R=mstarzinger@chromium.org BUG= TEST=mjsunit/harmony/iteration-optimization.js

Patch Set 1 #

Patch Set 2 : Add null/undefined check in crankshaft. #

Patch Set 3 : Rebase onto master; fix AstTyper for ForOfStatement #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -80 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 2	2 chunks	+3 lines, -13 lines	0 comments	Download
M	src/ast.h	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/flag-definitions.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2	1 chunk	+50 lines, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 2	2 chunks	+3 lines, -12 lines	0 comments	Download
M	src/parser.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/typing.cc	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 2	2 chunks	+3 lines, -12 lines	0 comments	Download
A +	test/mjsunit/harmony/iteration-optimization.js	View	1	1 chunk	+23 lines, -34 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wingo

7 years, 6 months ago (2013-06-07 11:19:33 UTC) #2

Updated patch is rebased onto master, and fixes the AstTyper to record the right
information for for-of.

Expand Messages | Collapse Messages