Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1573903002: Change some functions in ImeEngineObserver as not ChromeOS-only. (Closed)

Created:
4 years, 11 months ago by Azure Wei
Modified:
4 years, 11 months ago
Reviewers:
Shu Chen
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change some functions in ImeEngineObserver as not ChromeOS-only. This cl makes functions: OnActivate(), IsInterestedInKeyEvent(), OnSurroundingTextChanged() in ui::IMEEngineObserver not ChromeOS only, as these related input.ime.* API should be reused on Linux and Windows. Function GetCurrentScreenType() is declared virtual in ImeObserver, as it will be used for OnActivate(). BUG=517773 TEST=No compiling errors. Committed: https://crrev.com/a8dc1724d107578d46f10a232aa5b3fe51b5c6b6 Cr-Commit-Position: refs/heads/master@{#368564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -53 lines) Patch
M chrome/browser/extensions/api/input_ime/input_ime_api.h View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 2 chunks +39 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc View 4 chunks +1 line, -41 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/ime/ime_engine_observer.h View 4 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Azure Wei
Hi Shu, can you please review this cl? Thank you!
4 years, 11 months ago (2016-01-11 07:49:20 UTC) #3
Shu Chen
lgtm
4 years, 11 months ago (2016-01-11 08:13:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573903002/1
4 years, 11 months ago (2016-01-11 08:16:50 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-11 10:13:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573903002/1
4 years, 11 months ago (2016-01-11 11:06:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 11:10:26 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 11:11:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8dc1724d107578d46f10a232aa5b3fe51b5c6b6
Cr-Commit-Position: refs/heads/master@{#368564}

Powered by Google App Engine
This is Rietveld 408576698