Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1573843002: Make `chrome` target build without unused data members on Linux. (Closed)

Created:
4 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 11 months ago
Reviewers:
vabr (Chromium), jam
CC:
asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, tfarina, vabr+watchlistpasswordmanager_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@content_target
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make `chrome` target build without unused data members on Linux. This allows the `chrome` target to build with the following CL applied: https://codereview.chromium.org/1222403002 BUG=447445 Committed: https://crrev.com/ba00ad126606ef0d27410e40025ed3fcaad9f89c Cr-Commit-Position: refs/heads/master@{#369952}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Patch Set 3 : test compile #

Patch Set 4 : browsertest fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -28 lines) Patch
M chrome/browser/extensions/api/messaging/native_process_launcher.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/bad_clock_blocking_page.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/bad_clock_blocking_page.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/instance_id/instance_id_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/gcm_driver/instance_id/instance_id_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/user_script_loader.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573843002/1
4 years, 11 months ago (2016-01-10 17:42:59 UTC) #2
mlamouri (slow - plz ping)
4 years, 11 months ago (2016-01-10 17:43:18 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/156539)
4 years, 11 months ago (2016-01-10 17:46:27 UTC) #6
vabr (Chromium)
chrome/browser/password_manager/native_backend_gnome_x.* LGTM, thanks for the clan-up! Cheers, Vaclav
4 years, 11 months ago (2016-01-11 09:24:00 UTC) #8
jam
lgtm with comment https://codereview.chromium.org/1573843002/diff/1/chrome/browser/ui/views/toolbar/toolbar_action_view.cc File chrome/browser/ui/views/toolbar/toolbar_action_view.cc (right): https://codereview.chromium.org/1573843002/diff/1/chrome/browser/ui/views/toolbar/toolbar_action_view.cc#newcode59 chrome/browser/ui/views/toolbar/toolbar_action_view.cc:59: Profile* profile, no need to pass
4 years, 11 months ago (2016-01-13 16:18:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573843002/20001
4 years, 11 months ago (2016-01-15 09:22:20 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/166748)
4 years, 11 months ago (2016-01-15 09:32:40 UTC) #14
mlamouri (slow - plz ping)
https://codereview.chromium.org/1573843002/diff/1/chrome/browser/ui/views/toolbar/toolbar_action_view.cc File chrome/browser/ui/views/toolbar/toolbar_action_view.cc (right): https://codereview.chromium.org/1573843002/diff/1/chrome/browser/ui/views/toolbar/toolbar_action_view.cc#newcode59 chrome/browser/ui/views/toolbar/toolbar_action_view.cc:59: Profile* profile, On 2016/01/13 at 16:18:52, jam wrote: > ...
4 years, 11 months ago (2016-01-15 09:55:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573843002/40001
4 years, 11 months ago (2016-01-15 09:58:50 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/130232)
4 years, 11 months ago (2016-01-15 10:13:22 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573843002/60001
4 years, 11 months ago (2016-01-16 14:24:11 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-16 15:06:17 UTC) #24
commit-bot: I haz the power
4 years, 11 months ago (2016-01-16 15:07:49 UTC) #26
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ba00ad126606ef0d27410e40025ed3fcaad9f89c
Cr-Commit-Position: refs/heads/master@{#369952}

Powered by Google App Engine
This is Rietveld 408576698