Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1573633002: Implement support for Element.documentationComment in summaries. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement support for Element.documentationComment in summaries. Support for Element.docRange will be added in a future CL. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c0bd3091b1f8483d56f277d7392059684887ab83

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+673 lines, -9 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 38 chunks +219 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 7 chunks +20 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 7 chunks +23 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 12 chunks +141 lines, -0 lines 2 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 14 chunks +208 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 8 chunks +62 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-08 22:00:35 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1573633002/diff/1/pkg/analyzer/test/src/summary/resynthesize_test.dart File pkg/analyzer/test/src/summary/resynthesize_test.dart (right): https://codereview.chromium.org/1573633002/diff/1/pkg/analyzer/test/src/summary/resynthesize_test.dart#newcode202 pkg/analyzer/test/src/summary/resynthesize_test.dart:202: reason: desc); Do we want to support the ...
4 years, 11 months ago (2016-01-08 22:04:45 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as c0bd3091b1f8483d56f277d7392059684887ab83 (presubmit successful).
4 years, 11 months ago (2016-01-08 22:35:30 UTC) #5
Paul Berry
4 years, 11 months ago (2016-01-08 22:37:48 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1573633002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1573633002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:202: reason: desc);
On 2016/01/08 22:04:45, scheglov wrote:
> Do we want to support the (deprecated) `docRange` property?

Good question.  I don't know if it's really needed, but it was simple enough to
do: https://codereview.chromium.org/1564343004/

Powered by Google App Engine
This is Rietveld 408576698