Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_test.dart

Issue 1573633002: Implement support for Element.documentationComment in summaries. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/summary/resynthesize_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_test.dart b/pkg/analyzer/test/src/summary/resynthesize_test.dart
index 5f085faf71c13818e8bf42ebc543dfa4b3071207..ff858c799cb0ab14c1ca68dca1e9553838d79c59 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_test.dart
@@ -198,6 +198,8 @@ class ResynthTest extends ResolverTestCase {
expect(resynthesized.location, original.location, reason: desc);
expect(resynthesized.name, original.name);
expect(resynthesized.nameOffset, original.nameOffset, reason: desc);
+ expect(resynthesized.documentationComment, original.documentationComment,
+ reason: desc);
scheglov 2016/01/08 22:04:45 Do we want to support the (deprecated) `docRange`
Paul Berry 2016/01/08 22:37:47 Good question. I don't know if it's really needed
for (Modifier modifier in Modifier.values) {
if (modifier == Modifier.MIXIN) {
// Skipping for now. TODO(paulberry): fix.
@@ -531,6 +533,18 @@ class ResynthTest extends ResolverTestCase {
checkLibrary('class C = D with E, F; class D {} class E {} class F {}');
}
+ test_class_alias_documented() {
+ checkLibrary('''
+// Extra comment so doc comment offset != 0
+/**
+ * Docs
+ */
+class C = D with E;
+
+class D {}
+class E {}''');
+ }
+
test_class_alias_with_forwarding_constructors() {
addLibrarySource(
'/a.dart',
@@ -665,6 +679,30 @@ class E {
checkLibrary('class C { C.foo(); C.bar(); }');
}
+ test_class_documented() {
+ checkLibrary('''
+// Extra comment so doc comment offset != 0
+/**
+ * Docs
+ */
+class C {}''');
+ }
+
+ test_class_documented_with_references() {
+ checkLibrary('''
+/**
+ * Docs referring to [D] and [E]
+ */
+class C {}
+
+class D {}
+class E {}''');
+ }
+
+ test_class_documented_with_windows_line_endings() {
+ checkLibrary('/**\r\n * Docs\r\n */\r\nclass C {}');
+ }
+
test_class_field_const() {
checkLibrary('class C { static const int i = 0; }');
}
@@ -773,6 +811,16 @@ class E {
checkLibrary('class C {} class D {}');
}
+ test_constructor_documented() {
+ checkLibrary('''
+class C {
+ /**
+ * Docs
+ */
+ C();
+}''');
+ }
+
test_core() {
String uri = 'dart:core';
LibraryElementImpl original =
@@ -782,6 +830,25 @@ class E {
checkLibraryElements(original, resynthesized);
}
+ test_enum_documented() {
+ checkLibrary('''
+// Extra comment so doc comment offset != 0
+/**
+ * Docs
+ */
+enum E { v }''');
+ }
+
+ test_enum_value_documented() {
+ checkLibrary('''
+enum E {
+ /**
+ * Docs
+ */
+ v
+}''');
+ }
+
test_enum_values() {
checkLibrary('enum E { v1, v2 }');
}
@@ -811,6 +878,25 @@ class E {
checkLibrary('export "a.dart"; export "b.dart";');
}
+ test_field_documented() {
+ checkLibrary('''
+class C {
+ /**
+ * Docs
+ */
+ var x;
+}''');
+ }
+
+ test_function_documented() {
+ checkLibrary('''
+// Extra comment so doc comment offset != 0
+/**
+ * Docs
+ */
+f() {}''');
+ }
+
test_function_entry_point() {
checkLibrary('main() {}');
}
@@ -889,6 +975,15 @@ class E {
checkLibrary('f() {} g() {}');
}
+ test_getter_documented() {
+ checkLibrary('''
+// Extra comment so doc comment offset != 0
+/**
+ * Docs
+ */
+get x => null;''');
+ }
+
test_getter_external() {
checkLibrary('external int get x;');
}
@@ -927,6 +1022,15 @@ class E {
checkLibrary('');
}
+ test_library_documented() {
+ checkLibrary('''
+// Extra comment so doc comment offset != 0
+/**
+ * Docs
+ */
+library foo;''');
+ }
+
test_library_name_with_spaces() {
checkLibrary('library foo . bar ;');
}
@@ -935,6 +1039,16 @@ class E {
checkLibrary('library foo.bar;');
}
+ test_method_documented() {
+ checkLibrary('''
+class C {
+ /**
+ * Docs
+ */
+ f() {}
+}''');
+ }
+
test_method_parameter_parameters() {
checkLibrary('class C { f(g(x, y)) {} }');
}
@@ -1000,6 +1114,15 @@ class E {
checkLibrary('library my.lib; part "a.dart"; part "b.dart";');
}
+ test_setter_documented() {
+ checkLibrary('''
+// Extra comment so doc comment offset != 0
+/**
+ * Docs
+ */
+void set x(value) {}''');
+ }
+
test_setter_external() {
checkLibrary('external void set x(int value);');
}
@@ -1142,6 +1265,15 @@ class E {
checkLibrary('import "dart:core" as core; core.C c;', allowErrors: true);
}
+ test_typedef_documented() {
+ checkLibrary('''
+// Extra comment so doc comment offset != 0
+/**
+ * Docs
+ */
+typedef F();''');
+ }
+
test_typedef_parameter_parameters() {
checkLibrary('typedef F(g(x, y));');
}
@@ -1206,6 +1338,15 @@ class E {
checkLibrary('const int i = 0;');
}
+ test_variable_documented() {
+ checkLibrary('''
+// Extra comment so doc comment offset != 0
+/**
+ * Docs
+ */
+var x;''');
+ }
+
test_variable_implicit_type() {
checkLibrary('var x;');
}
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_elements.dart ('k') | pkg/analyzer/test/src/summary/summary_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698