trace compare_nil_ic state in --trace-ic output

src/code-stubs.cc

Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index 312febc1aa5701d0de3d3a10534d809f0db74647..cf3a6f59918346c5b7014ea8d78bd4d01bf3eea6 100644
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -410,6 +410,7 @@ void ICCompareStub::Generate(MacroAssembler* masm) {
 
 void CompareNilICStub::Record(Handle<Object> object) {
   ASSERT(types_ != Types::FullCompare());
+  Types old_types(types_);
   if (equality_kind_ == kStrictEquality) {
     // When testing for strict equality only one value will evaluate to true
     types_.RemoveAll();
@@ -430,6 +431,22 @@ void CompareNilICStub::Record(Handle<Object> object) {
       types_.Add(MONOMORPHIC_MAP);
     }
   }
+  old_types.TraceTransition(types_);

[Sven Panne, 2013/05/24 09:02:44]

For consistency, call the tracing in CompareNilIC::CompareNil. We should
probably do this for ToBoolean, too, BTW.

+}
+
+
+void CompareNilICStub::Types::TraceTransition(Types to) const {
+  if (!FLAG_trace_ic) return;
+  char buffer[100];
+  NoAllocationStringAllocator allocator(buffer,
+                                        static_cast<unsigned>(sizeof(buffer)));
+  StringStream stream(&allocator);
+  stream.Add("[CompareNilIC (");

[Sven Panne, 2013/05/24 09:02:44]

Nit: To make things gradually more consistent, remove the parentheses and use
"=>" instead of "->" in the output. Reason: We intend to use "->" for a
different purpose when tracing binary ops.

+  Print(&stream);
+  stream.Add("->");
+  to.Print(&stream);
+  stream.Add(")]\n");
+  stream.OutputToStdOut();
 }