trace compare_nil_ic state in --trace-ic output

src/code-stubs.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 392 matching lines @@
       break;
     case CompareIC::GENERIC:
       GenerateGeneric(masm);
       break;
   }
 }
 
 
 void CompareNilICStub::Record(Handle<Object> object) {
   ASSERT(types_ != Types::FullCompare());
+  Types old_types(types_);
   if (equality_kind_ == kStrictEquality) {
     // When testing for strict equality only one value will evaluate to true
     types_.RemoveAll();
     types_.Add((nil_value_ == kNullValue) ? NULL_TYPE:
                                             UNDEFINED);
   } else {
     if (object->IsNull()) {
       types_.Add(NULL_TYPE);
     } else if (object->IsUndefined()) {
       types_.Add(UNDEFINED);
     } else if (object->IsUndetectableObject() ||
                object->IsOddball() ||
                !object->IsHeapObject()) {
       types_ = Types::FullCompare();
     } else if (IsMonomorphic()) {
       types_ = Types::FullCompare();
     } else {
       types_.Add(MONOMORPHIC_MAP);
     }
   }
+  old_types.TraceTransition(types_);

[Sven Panne, 2013/05/24 09:02:44]

For consistency, call the tracing in CompareNilIC::CompareNil. We should
probably do this for ToBoolean, too, BTW.

 }
 
 
+void CompareNilICStub::Types::TraceTransition(Types to) const {
+  if (!FLAG_trace_ic) return;
+  char buffer[100];
+  NoAllocationStringAllocator allocator(buffer,
+                                        static_cast<unsigned>(sizeof(buffer)));
+  StringStream stream(&allocator);
+  stream.Add("[CompareNilIC (");

[Sven Panne, 2013/05/24 09:02:44]

Nit: To make things gradually more consistent, remove the parentheses and use
"=>" instead of "->" in the output. Reason: We intend to use "->" for a
different purpose when tracing binary ops.

+  Print(&stream);
+  stream.Add("->");
+  to.Print(&stream);
+  stream.Add(")]\n");
+  stream.OutputToStdOut();
+}
+
+
 void CompareNilICStub::PrintName(StringStream* stream) {
   stream->Add("CompareNilICStub_");
   types_.Print(stream);
   stream->Add((nil_value_ == kNullValue) ? "(NullValue|":
                                            "(UndefinedValue|");
   stream->Add((equality_kind_ == kStrictEquality) ? "StrictEquality)":
                                                     "NonStrictEquality)");
 }
 
 
@@ skipping 297 matching lines @@
   } else if (argument_count >= 2) {
     argument_count_ = MORE_THAN_ONE;
   } else {
     UNREACHABLE();
   }
   ArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
 }
 
 
 } }  // namespace v8::internal