trace compare_nil_ic state in --trace-ic output

trace compare_nil_ic state in --trace-ic output

BUG=
R=svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=14808

[Sven Panne, 2013-05-24 09:02:44]

https://codereview.chromium.org/15735020/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/15735020/diff/1/src/code-stubs.cc#newcode434
src/code-stubs.cc:434: old_types.TraceTransition(types_);
For consistency, call the tracing in CompareNilIC::CompareNil. We should
probably do this for ToBoolean, too, BTW.

https://codereview.chromium.org/15735020/diff/1/src/code-stubs.cc#newcode444
src/code-stubs.cc:444: stream.Add("[CompareNilIC (");
Nit: To make things gradually more consistent, remove the parentheses and use
"=>" instead of "->" in the output. Reason: We intend to use "->" for a
different purpose when tracing binary ops.

[oliv, 2013-05-24 12:26:59]

On 2013/05/24 09:02:44, Sven Panne wrote:
> https://codereview.chromium.org/15735020/diff/1/src/code-stubs.cc
> File src/code-stubs.cc (right):
> 
> https://codereview.chromium.org/15735020/diff/1/src/code-stubs.cc#newcode434
> src/code-stubs.cc:434: old_types.TraceTransition(types_);
> For consistency, call the tracing in CompareNilIC::CompareNil. We should
> probably do this for ToBoolean, too, BTW.
> 
> https://codereview.chromium.org/15735020/diff/1/src/code-stubs.cc#newcode444
> src/code-stubs.cc:444: stream.Add("[CompareNilIC (");
> Nit: To make things gradually more consistent, remove the parentheses and use
> "=>" instead of "->" in the output. Reason: We intend to use "->" for a
> different purpose when tracing binary ops.

ok

[Sven Panne, 2013-05-24 12:39:23]

lgtm

[oliv, 2013-05-24 15:20:55]

Committed patchset #2 manually as r14808 (presubmit successful).