Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 15732019: Revert 151179 "On IE and FireFox, they treats contenteditable="f..." (Closed)

Created:
7 years, 7 months ago by yosin_UTC9
Modified:
7 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, eae+blinkwatch
Visibility:
Public.

Description

Revert 151179 "On IE and FireFox, they treats contenteditable="f..." > On IE and FireFox, they treats contenteditable="false" element as atomic element. When moving caret around it, cursor is placed at start/end of it. > > This patch changes Blink(Chrome) behavior as IE and FireFox. > > This patch updates tests for behavior change: > - editing/selection/4889598.html: Removed, because updated version of mixed-editability-3.html does same test, line motion around uneditable table element. > - editing/selection/mixed-editability-3.html: Changed to cover forward and backward line motion and verify by script rather than editing log and render tree for ease of future maintenance. > - editing/selection/move-by-line-004.html: Changed for new behavior. Caret can't go cross uneditable table cell as FireFox. > > BUG=238000 > > Review URL: https://chromiumcodereview.appspot.com/14794012 NOTRY=true TBR=yosin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -219 lines) Patch
D LayoutTests/editing/deleting/delete-mixed-editable-content-002.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/editing/deleting/delete-mixed-editable-content-002-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
A LayoutTests/editing/selection/4889598.html View 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/editing/selection/4889598-expected.txt View 1 chunk +65 lines, -0 lines 0 comments Download
M LayoutTests/editing/selection/mixed-editability-3.html View 1 chunk +11 lines, -23 lines 0 comments Download
M LayoutTests/editing/selection/mixed-editability-3-expected.txt View 1 chunk +32 lines, -21 lines 0 comments Download
M LayoutTests/editing/selection/move-by-line-004.html View 2 chunks +34 lines, -25 lines 0 comments Download
M LayoutTests/editing/selection/move-by-line-004-expected.txt View 1 chunk +5 lines, -14 lines 0 comments Download
M LayoutTests/editing/selection/resources/js-test-selection-shared.js View 1 chunk +0 lines, -55 lines 0 comments Download
A LayoutTests/platform/chromium-linux/editing/selection/4889598-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-linux/editing/selection/mixed-editability-3-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-mac-lion/editing/selection/4889598-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-mac-lion/editing/selection/mixed-editability-3-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-mac-snowleopard/editing/selection/4889598-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-mac-snowleopard/editing/selection/mixed-editability-3-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-mac/editing/selection/4889598-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-mac/editing/selection/mixed-editability-3-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-win/editing/selection/4889598-expected.png View Binary file 0 comments Download
A LayoutTests/platform/chromium-win/editing/selection/4889598-expected.txt View 1 chunk +65 lines, -0 lines 0 comments Download
A LayoutTests/platform/chromium-win/editing/selection/mixed-editability-3-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/chromium-win/editing/selection/mixed-editability-3-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/htmlediting.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/htmlediting.cpp View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
yosin_UTC9
7 years, 7 months ago (2013-05-27 09:09:56 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r151185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698