Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1573133002: Need to examine the *bottom* of fragmented content. (Closed)

Created:
4 years, 11 months ago by mstensho (USE GERRIT)
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Need to examine the *bottom* of fragmented content. Content may cross fragmentainer boundaries, and when evaluating the need for appending additional fragmentainer groups, we need to look at the bottom of the content, not the top. This CL is a prerequisite to fixing bug 552615, but note that it doesn't fix anything there on its own. BUG=552615 R=leviw@chromium.org Committed: https://crrev.com/17107c91aefa150a7f1f9d6c572ba63091ec6126 Cr-Commit-Position: refs/heads/master@{#370323}

Patch Set 1 #

Patch Set 2 : Slim down the patch; back out columnSetAtBlockOffset() changes. This was already broken prior to th… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -22 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/nested-with-single-empty-block.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/nested-with-single-empty-block-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/nested-with-single-tall-line.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/nested-with-single-tall-line-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlowThread.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 6 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mstensho (USE GERRIT)
4 years, 11 months ago (2016-01-11 20:15:20 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 11 months ago (2016-01-20 00:33:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573133002/20001
4 years, 11 months ago (2016-01-20 00:38:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-20 05:24:31 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 05:25:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/17107c91aefa150a7f1f9d6c572ba63091ec6126
Cr-Commit-Position: refs/heads/master@{#370323}

Powered by Google App Engine
This is Rietveld 408576698