Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h

Issue 1573133002: Need to examine the *bottom* of fragmented content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Slim down the patch; back out columnSetAtBlockOffset() changes. This was already broken prior to th… Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h
index bacdc4e7363564750291bc16ddb78bbf0890ccce..33ad6c35c8452ccf0e35fd0e880ffd1308605b57 100644
--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h
+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h
@@ -197,7 +197,7 @@ public:
// If we've run out of columns in the last fragmentainer group (column row), we have to insert
// another fragmentainer group in order to hold more columns. This means that we're moving to
// the next outer column (in the enclosing fragmentation context).
- void appendNewFragmentainerGroupIfNeeded(LayoutUnit offsetInFlowThread);
+ void appendNewFragmentainerGroupIfNeeded(LayoutUnit bottomOffsetInFlowThread);
// Implementing FragmentationContext:
bool isFragmentainerLogicalHeightKnown() final;
@@ -229,7 +229,7 @@ private:
void computePreferredLogicalWidths() override;
void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const override;
void updateLogicalWidth() override;
- void contentWasLaidOut(LayoutUnit logicalTopInFlowThreadAfterPagination) override;
+ void contentWasLaidOut(LayoutUnit logicalBottomInFlowThreadAfterPagination) override;
// The last set we worked on. It's not to be used as the "current set". The concept of a
// "current set" is difficult, since layout may jump back and forth in the tree, due to wrong

Powered by Google App Engine
This is Rietveld 408576698