Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 15730005: cc: Don't make AcquireLayerTextures force a commit. (Closed)

Created:
7 years, 7 months ago by piman
Modified:
7 years, 5 months ago
Reviewers:
danakj, jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Don't make AcquireLayerTextures force a commit. Clients will just do it from the main thread when they're ready. BUG=243311 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211210

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Don't SetNeedsCommit at all #

Patch Set 4 : rebase + fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M cc/scheduler/scheduler_state_machine.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 2 3 4 chunks +25 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
piman
7 years, 7 months ago (2013-05-25 00:39:57 UTC) #1
jamesr
word, lgtm did Dana's patch provide test coverage for this or is that still tbd?
7 years, 7 months ago (2013-05-25 00:44:17 UTC) #2
piman
On Fri, May 24, 2013 at 5:44 PM, <jamesr@chromium.org> wrote: > word, lgtm > > ...
7 years, 7 months ago (2013-05-25 00:50:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/15730005/7001
7 years, 7 months ago (2013-05-25 00:53:08 UTC) #4
piman
On Fri, May 24, 2013 at 5:50 PM, Antoine Labour <piman@chromium.org> wrote: > > > ...
7 years, 7 months ago (2013-05-25 00:54:20 UTC) #5
jamesr
I can't think of anything brilliant either. I agree this patch is good to have ...
7 years, 7 months ago (2013-05-25 00:57:19 UTC) #6
piman
On 2013/05/25 00:57:19, jamesr wrote: > I can't think of anything brilliant either. I agree ...
7 years, 7 months ago (2013-05-25 01:17:08 UTC) #7
piman
On Fri, May 24, 2013 at 6:17 PM, <piman@chromium.org> wrote: > On 2013/05/25 00:57:19, jamesr ...
7 years, 7 months ago (2013-05-25 01:47:03 UTC) #8
danakj
On 2013/05/25 01:47:03, piman wrote: > On Fri, May 24, 2013 at 6:17 PM, <mailto:piman@chromium.org> ...
7 years, 6 months ago (2013-06-12 17:30:45 UTC) #9
piman
On 2013/06/12 17:30:45, danakj wrote: > On 2013/05/25 01:47:03, piman wrote: > > On Fri, ...
7 years, 6 months ago (2013-06-12 19:38:43 UTC) #10
jamesr
On 2013/06/12 19:38:43, piman wrote: > I have a WIP patch, but it's not ready ...
7 years, 5 months ago (2013-07-09 06:32:20 UTC) #11
piman
PTAL with a new version that doesn't force a commit to happen (see bug).
7 years, 5 months ago (2013-07-11 02:43:48 UTC) #12
danakj
Removing code from scheduler state machine LGTM
7 years, 5 months ago (2013-07-11 15:38:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/15730005/42001
7 years, 5 months ago (2013-07-11 17:25:30 UTC) #14
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 20:54:25 UTC) #15
Message was sent while issue was closed.
Change committed as 211210

Powered by Google App Engine
This is Rietveld 408576698