Disable TLS destructors on Windows before calling abort() for an ASSERT.

Disable TLS destructors on Windows before calling abort() for an ASSERT.

This fixes some flaky failures and timeouts on Windows in tests where
an ASSERT fails.

This change requires Using OS::Abort in platform/assert.cc so that the
flag disabling tls destructors can be set.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/963946af007bc67296177b92aebc512187bd59e7

[zra, 2016-01-11 16:16:33]

zra@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-01-11 18:05:28]

LGTM

https://codereview.chromium.org/1572913002/diff/20001/runtime/platform/assert.cc
File runtime/platform/assert.cc (right):

https://codereview.chromium.org/1572913002/diff/20001/runtime/platform/assert...
runtime/platform/assert.cc:11: #include "vm/os.h"
Can platform depend on vm/ ?

[zra, 2016-01-11 18:33:41]

https://codereview.chromium.org/1572913002/diff/20001/runtime/platform/assert.cc
File runtime/platform/assert.cc (right):

https://codereview.chromium.org/1572913002/diff/20001/runtime/platform/assert...
runtime/platform/assert.cc:11: #include "vm/os.h"
On 2016/01/11 18:05:28, Cutch wrote:
> Can platform depend on vm/ ?

text_buffer.{h,cc} already does, and to me it seems preferable to duplicating
assert.{h,cc} across bin/ and vm/ (unless/until platform/ goes away and we
duplicate everything anyway.)

[zra, 2016-01-11 18:35:03]

Description was changed from

==========
Disable TLS destructors on Windows before calling abort() for an ASSERT.

This fixes some flaky failures and timeouts on Windows in tests where
an ASSERT fails.

This change requires Using OS::Abort in platform/assert.cc so that the
flag disabling tls destructors can be set.
==========

to

==========
Disable TLS destructors on Windows before calling abort() for an ASSERT.

This fixes some flaky failures and timeouts on Windows in tests where
an ASSERT fails.

This change requires Using OS::Abort in platform/assert.cc so that the
flag disabling tls destructors can be set.

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/963946af007bc67296177b92aebc512187bd59e7
==========

[zra, 2016-01-11 18:35:04]

Committed patchset #2 (id:20001) manually as
963946af007bc67296177b92aebc512187bd59e7 (presubmit successful).