Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: runtime/platform/assert.cc

Issue 1572913002: Disable TLS destructors on Windows before calling abort() for an ASSERT. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/os_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/platform/assert.cc
diff --git a/runtime/platform/assert.cc b/runtime/platform/assert.cc
index 41f42f4353f178c2046afc541f4722f8419aa685..e9d1c4fa301e66db915f676132275b292b21a5c6 100644
--- a/runtime/platform/assert.cc
+++ b/runtime/platform/assert.cc
@@ -8,6 +8,7 @@
#include <string>
#include "platform/globals.h"
+#include "vm/os.h"
Cutch 2016/01/11 18:05:28 Can platform depend on vm/ ?
zra 2016/01/11 18:33:41 text_buffer.{h,cc} already does, and to me it seem
namespace dart {
@@ -38,7 +39,7 @@ void DynamicAssertionHelper::Fail(const char* format, ...) {
// TODO(5411324): replace std::abort with OS::Abort so that we can handle
// restoring of signal handlers before aborting.
if (kind_ == ASSERT) {
- abort();
+ OS::Abort();
}
static bool failed = false;
if (!failed) {
« no previous file with comments | « no previous file | runtime/vm/os_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698