chrome/browser/ui/chrome_bubble_manager.h - Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/chrome_bubble_manager.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/chrome_bubble_manager.h

diff --git a/chrome/browser/ui/chrome_bubble_manager.h b/chrome/browser/ui/chrome_bubble_manager.h

index 4b605b33f0f0b1c257c302dee8fc06feb7789592..1f7eb355f4602d7efc892f811380f316896817ad 100644

--- a/chrome/browser/ui/chrome_bubble_manager.h

+++ b/chrome/browser/ui/chrome_bubble_manager.h

@@ -28,6 +28,7 @@ class ChromeBubbleManager : public BubbleManager,

int reason) override;

// content::WebContentsObserver:

+ void FrameDeleted(content::RenderFrameHost* render_frame_host) override;

void DidToggleFullscreenModeForTab(bool entered_fullscreen,

bool will_cause_resize) override;

void NavigationEntryCommitted(

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/chrome_bubble_manager.cc » ('j') | no next file with comments »