Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: chrome/browser/ui/chrome_bubble_manager.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/chrome_bubble_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_ 5 #ifndef CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
6 #define CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_ 6 #define CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h" 9 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
10 #include "components/bubble/bubble_manager.h" 10 #include "components/bubble/bubble_manager.h"
(...skipping 10 matching lines...) Expand all
21 21
22 // TabStripModelObserver: 22 // TabStripModelObserver:
23 void TabDetachedAt(content::WebContents* contents, int index) override; 23 void TabDetachedAt(content::WebContents* contents, int index) override;
24 void TabDeactivated(content::WebContents* contents) override; 24 void TabDeactivated(content::WebContents* contents) override;
25 void ActiveTabChanged(content::WebContents* old_contents, 25 void ActiveTabChanged(content::WebContents* old_contents,
26 content::WebContents* new_contents, 26 content::WebContents* new_contents,
27 int index, 27 int index,
28 int reason) override; 28 int reason) override;
29 29
30 // content::WebContentsObserver: 30 // content::WebContentsObserver:
31 void FrameDeleted(content::RenderFrameHost* render_frame_host) override;
31 void DidToggleFullscreenModeForTab(bool entered_fullscreen, 32 void DidToggleFullscreenModeForTab(bool entered_fullscreen,
32 bool will_cause_resize) override; 33 bool will_cause_resize) override;
33 void NavigationEntryCommitted( 34 void NavigationEntryCommitted(
34 const content::LoadCommittedDetails& load_details) override; 35 const content::LoadCommittedDetails& load_details) override;
35 36
36 private: 37 private:
37 class ChromeBubbleMetrics : public BubbleManager::BubbleManagerObserver { 38 class ChromeBubbleMetrics : public BubbleManager::BubbleManagerObserver {
38 public: 39 public:
39 ChromeBubbleMetrics() {} 40 ChromeBubbleMetrics() {}
40 ~ChromeBubbleMetrics() override {} 41 ~ChromeBubbleMetrics() override {}
41 42
42 // BubbleManager::BubbleManagerObserver: 43 // BubbleManager::BubbleManagerObserver:
43 void OnBubbleNeverShown(BubbleReference bubble) override; 44 void OnBubbleNeverShown(BubbleReference bubble) override;
44 void OnBubbleClosed(BubbleReference bubble, 45 void OnBubbleClosed(BubbleReference bubble,
45 BubbleCloseReason reason) override; 46 BubbleCloseReason reason) override;
46 47
47 private: 48 private:
48 DISALLOW_COPY_AND_ASSIGN(ChromeBubbleMetrics); 49 DISALLOW_COPY_AND_ASSIGN(ChromeBubbleMetrics);
49 }; 50 };
50 51
51 TabStripModel* tab_strip_model_; 52 TabStripModel* tab_strip_model_;
52 ChromeBubbleMetrics chrome_bubble_metrics_; 53 ChromeBubbleMetrics chrome_bubble_metrics_;
53 54
54 DISALLOW_COPY_AND_ASSIGN(ChromeBubbleManager); 55 DISALLOW_COPY_AND_ASSIGN(ChromeBubbleManager);
55 }; 56 };
56 57
57 #endif // CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_ 58 #endif // CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/chrome_bubble_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698