Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: chrome/browser/usb/web_usb_permission_bubble.cc

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Clean up Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/usb/web_usb_permission_bubble.cc
diff --git a/chrome/browser/usb/web_usb_permission_bubble.cc b/chrome/browser/usb/web_usb_permission_bubble.cc
index d1f7a8f448efaac8db9987b27959f9f7709de893..6ba7d266ef6fbdb2dbaee68bfb40641487393b64 100644
--- a/chrome/browser/usb/web_usb_permission_bubble.cc
+++ b/chrome/browser/usb/web_usb_permission_bubble.cc
@@ -34,7 +34,8 @@ void ChromeWebUsbPermissionBubble::GetPermission(
content::WebContents::FromRenderFrameHost(render_frame_host_);
Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
scoped_ptr<UsbChooserBubbleDelegate> bubble_delegate(
- new UsbChooserBubbleDelegate(browser, std::move(device_filters),
+ new UsbChooserBubbleDelegate(render_frame_host_,
+ std::move(device_filters),
render_frame_host_, callback));
UsbChooserBubbleDelegate* bubble_delegate_ptr = bubble_delegate.get();
BubbleReference bubble_controller =

Powered by Google App Engine
This is Rietveld 408576698