chrome/browser/usb/usb_chooser_bubble_delegate.cc - Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/usb/usb_chooser_bubble_delegate.cc

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Clean up Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/extensions/extension_installed_bubble.cc ('K') | « chrome/browser/usb/usb_chooser_bubble_delegate.h ('k') | chrome/browser/usb/web_usb_permission_bubble.cc » ('j') | components/bubble/bubble_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/usb/usb_chooser_bubble_delegate.cc

diff --git a/chrome/browser/usb/usb_chooser_bubble_delegate.cc b/chrome/browser/usb/usb_chooser_bubble_delegate.cc

index 99e7b65690717be99d2c1218f010a72b74da46f6..7ef9ea53c4f5c53e9e3f826aa17cd9e0311a5658 100644

--- a/chrome/browser/usb/usb_chooser_bubble_delegate.cc

+++ b/chrome/browser/usb/usb_chooser_bubble_delegate.cc

@@ -73,11 +73,11 @@ bool FindInAllowedOrigins(const device::WebUsbAllowedOrigins* allowed_origins,

} // namespace

UsbChooserBubbleDelegate::UsbChooserBubbleDelegate(

- Browser* browser,

+ content::RenderFrameHost* owner,

mojo::Array<device::usb::DeviceFilterPtr> device_filters,

content::RenderFrameHost* render_frame_host,

const webusb::WebUsbPermissionBubble::GetPermissionCallback& callback)

- : ChooserBubbleDelegate(browser),

+ : ChooserBubbleDelegate(owner),

render_frame_host_(render_frame_host),

callback_(callback),

usb_service_observer_(this),