chrome: fix gn check errors for "test_support" target under app directory

chrome: fix gn check errors for "test_support" target under app directory

Checked on Linux with the following command lines:

$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/app/*

BUG=367595, 376000
R=thestig@chromium.org
TBR=brettw@chromium.org

Committed: https://crrev.com/8e584883ca05166e6f797a66978adc4aa9da8a8c
Cr-Commit-Position: refs/heads/master@{#368491}

[Lei Zhang, 2016-01-08 20:21:36]

lgtm

https://codereview.chromium.org/1572673002/diff/100001/chrome/app/BUILD.gn
File chrome/app/BUILD.gn (right):

https://codereview.chromium.org/1572673002/diff/100001/chrome/app/BUILD.gn#ne...
chrome/app/BUILD.gn:325: "//chrome/browser/policy:path_parser",
win/mac only?

[tfarina, 2016-01-08 22:03:52]

tfarina@chromium.org changed reviewers:
+ brettw@chromium.org

[tfarina, 2016-01-08 22:03:52]

TBRing Brett for .gn

https://codereview.chromium.org/1572673002/diff/100001/chrome/app/BUILD.gn
File chrome/app/BUILD.gn (right):

https://codereview.chromium.org/1572673002/diff/100001/chrome/app/BUILD.gn#ne...
chrome/app/BUILD.gn:325: "//chrome/browser/policy:path_parser",
On 2016/01/08 20:21:36, Lei Zhang wrote:
> win/mac only?

Done.

[tfarina, 2016-01-08 22:04:44]

Description was changed from

==========
chrome: fix gn check errors for "test_support" target under app directory

Checked on Linux with the following command lines:

$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/app/*

BUG=367595,376000
R=thestig@chromium.org
==========

to

==========
chrome: fix gn check errors for "test_support" target under app directory

Checked on Linux with the following command lines:

$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/app/*

BUG=367595,376000
R=thestig@chromium.org
TBR=brettw@chromium.org
==========

[tfarina, 2016-01-08 22:06:15]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2016-01-08 22:06:15]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1572673002/#ps120001
(title: "path_parser only for mac or win")

[commit-bot: I haz the power, 2016-01-08 22:07:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572673002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572673002/120001

[tfarina, 2016-01-08 23:07:31]

https://codereview.chromium.org/1572673002/diff/100001/chrome/app/BUILD.gn
File chrome/app/BUILD.gn (right):

https://codereview.chromium.org/1572673002/diff/100001/chrome/app/BUILD.gn#ne...
chrome/app/BUILD.gn:325: "//chrome/browser/policy:path_parser",
On 2016/01/08 22:03:52, tfarina wrote:
> On 2016/01/08 20:21:36, Lei Zhang wrote:
> > win/mac only?
> 
> Done.

Meh, unfortunately, gn check is not able to know the include is under platform
#ifdefs. Reverting this change.

[tfarina, 2016-01-08 23:09:38]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2016-01-08 23:09:38]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1572673002/#ps140001
(title: "revert path_parser change - gn check does not understand it yet")

[commit-bot: I haz the power, 2016-01-08 23:12:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572673002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572673002/140001

[commit-bot: I haz the power, 2016-01-09 00:50:22]

Description was changed from

==========
chrome: fix gn check errors for "test_support" target under app directory

Checked on Linux with the following command lines:

$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/app/*

BUG=367595,376000
R=thestig@chromium.org
TBR=brettw@chromium.org
==========

to

==========
chrome: fix gn check errors for "test_support" target under app directory

Checked on Linux with the following command lines:

$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/app/*

BUG=367595,376000
R=thestig@chromium.org
TBR=brettw@chromium.org
==========

[commit-bot: I haz the power, 2016-01-09 00:50:22]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-01-09 00:52:07]

Description was changed from

==========
chrome: fix gn check errors for "test_support" target under app directory

Checked on Linux with the following command lines:

$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/app/*

BUG=367595,376000
R=thestig@chromium.org
TBR=brettw@chromium.org
==========

to

==========
chrome: fix gn check errors for "test_support" target under app directory

Checked on Linux with the following command lines:

$ gn gen out-gn/Release --args='is_debug=false is_component_build=false
symbol_level=1'
$ gn check out-gn/Release //chrome/app/*

BUG=367595,376000
R=thestig@chromium.org
TBR=brettw@chromium.org

Committed: https://crrev.com/8e584883ca05166e6f797a66978adc4aa9da8a8c
Cr-Commit-Position: refs/heads/master@{#368491}
==========

[commit-bot: I haz the power, 2016-01-09 00:52:08]

Patchset 8 (id:??) landed as
https://crrev.com/8e584883ca05166e6f797a66978adc4aa9da8a8c
Cr-Commit-Position: refs/heads/master@{#368491}