Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: .gn

Issue 1572673002: chrome: fix gn check errors for "test_support" target under app directory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert path_parser change - gn check does not understand it yet Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/app/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # This file is used by the GN meta build system to find the root of the source 1 # This file is used by the GN meta build system to find the root of the source
2 # tree and to set startup options. For documentation on the values set in this 2 # tree and to set startup options. For documentation on the values set in this
3 # file, run "gn help dotfile" at the command line. 3 # file, run "gn help dotfile" at the command line.
4 4
5 # The location of the build configuration file. 5 # The location of the build configuration file.
6 buildconfig = "//build/config/BUILDCONFIG.gn" 6 buildconfig = "//build/config/BUILDCONFIG.gn"
7 7
8 # The secondary source root is a parallel directory tree where 8 # The secondary source root is a parallel directory tree where
9 # GN build files are placed when they can not be placed directly 9 # GN build files are placed when they can not be placed directly
10 # in the source tree, e.g. for third party source trees. 10 # in the source tree, e.g. for third party source trees.
11 secondary_source = "//build/secondary/" 11 secondary_source = "//build/secondary/"
12 12
13 # These are the targets to check headers for by default. The files in targets 13 # These are the targets to check headers for by default. The files in targets
14 # matching these patterns (see "gn help label_pattern" for format) will have 14 # matching these patterns (see "gn help label_pattern" for format) will have
15 # their includes checked for proper dependencies when you run either 15 # their includes checked for proper dependencies when you run either
16 # "gn check" or "gn gen --check". 16 # "gn check" or "gn gen --check".
17 check_targets = [ 17 check_targets = [
18 #"//apps/*", # Medium-hard. 18 #"//apps/*", # Medium-hard.
19 #"//ash/*", # Medium-hard. 19 #"//ash/*", # Medium-hard.
20 "//base/*", 20 "//base/*",
21 "//blink/*", 21 "//blink/*",
22 "//breakpad/*", 22 "//breakpad/*",
23 "//build/*", 23 "//build/*",
24 "//cc/*", 24 "//cc/*",
25 25
26 #"//chrome/*", # Epic number of errors. 26 #"//chrome/*", # Epic number of errors.
27 "//chrome/app/*",
27 "//chrome/common/*", 28 "//chrome/common/*",
28 "//chrome/installer/*", 29 "//chrome/installer/*",
29 "//chrome/third_party/mozilla_security_manager/*", 30 "//chrome/third_party/mozilla_security_manager/*",
30 "//chrome/tools/*", 31 "//chrome/tools/*",
31 "//chrome/utility/*", 32 "//chrome/utility/*",
32 "//chromecast/*", 33 "//chromecast/*",
33 "//chrome_elf/*", 34 "//chrome_elf/*",
34 "//cloud_print/*", 35 "//cloud_print/*",
35 "//components/*", 36 "//components/*",
36 37
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 "//tools/gn/format_test_data/055.golden", 230 "//tools/gn/format_test_data/055.golden",
230 "//tools/gn/function_exec_script.cc", 231 "//tools/gn/function_exec_script.cc",
231 "//tools/gn/gn.gyp", 232 "//tools/gn/gn.gyp",
232 "//tools/gn/input_conversion.cc", 233 "//tools/gn/input_conversion.cc",
233 "//tools/gn/misc/emacs/gn.el", 234 "//tools/gn/misc/emacs/gn.el",
234 "//tools/gn/misc/vim/syntax/gn.vim", 235 "//tools/gn/misc/vim/syntax/gn.vim",
235 "//tools/gn/setup.cc", 236 "//tools/gn/setup.cc",
236 "//ui/accessibility/BUILD.gn", 237 "//ui/accessibility/BUILD.gn",
237 "//ui/views/BUILD.gn", 238 "//ui/views/BUILD.gn",
238 ] 239 ]
OLDNEW
« no previous file with comments | « no previous file | chrome/app/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698