Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1572433002: [Media Router] Add Connecting state to PresentationConnection to bring align with spec (Closed)

Created:
4 years, 11 months ago by imcheng
Modified:
4 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, media-router+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Add Connecting state to PresentationConnection. BUG=575351 Committed: https://crrev.com/dfe5ea3cd3f800192f48224f6d5aaa142ba8cceb Cr-Commit-Position: refs/heads/master@{#368761}

Patch Set 1 #

Patch Set 2 : Reverted Blink stuff for now #

Patch Set 3 : compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/browser/media/router/media_router.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/router/media_router_type_converters.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/presentation/presentation_type_converters.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/presentation/presentation_service.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/presentation_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M extensions/renderer/resources/media_router_bindings.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
imcheng
4 years, 11 months ago (2016-01-08 18:09:07 UTC) #4
imcheng
PTAL
4 years, 11 months ago (2016-01-08 18:09:14 UTC) #5
mark a. foltz
+mlamouri LGTM I don't think we should land the rest of the patch in modules/presentation ...
4 years, 11 months ago (2016-01-09 00:03:31 UTC) #7
mlamouri (slow - plz ping)
lgtm. We indeed need to send an intent to ship before shipping the new state ...
4 years, 11 months ago (2016-01-11 17:39:07 UTC) #8
imcheng
Reverted Blink stuff for now and added TODO in PresentationDispatcher.
4 years, 11 months ago (2016-01-11 20:07:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1572433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1572433002/40001
4 years, 11 months ago (2016-01-12 00:38:40 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-12 01:36:03 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 01:37:04 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dfe5ea3cd3f800192f48224f6d5aaa142ba8cceb
Cr-Commit-Position: refs/heads/master@{#368761}

Powered by Google App Engine
This is Rietveld 408576698