Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1967)

Unified Diff: content/renderer/presentation/presentation_dispatcher.cc

Issue 1572433002: [Media Router] Add Connecting state to PresentationConnection to bring align with spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/presentation/presentation_dispatcher.cc
diff --git a/content/renderer/presentation/presentation_dispatcher.cc b/content/renderer/presentation/presentation_dispatcher.cc
index 33fe33c258efb3d55ec1b3890c7fd57177e22d14..bfe9a49aed538e9047e665cbcb1ffb99aa00cb5a 100644
--- a/content/renderer/presentation/presentation_dispatcher.cc
+++ b/content/renderer/presentation/presentation_dispatcher.cc
@@ -42,16 +42,17 @@ blink::WebPresentationError::ErrorType GetWebPresentationErrorTypeFromMojo(
blink::WebPresentationConnectionState GetWebPresentationConnectionStateFromMojo(
presentation::PresentationConnectionState mojoSessionState) {
switch (mojoSessionState) {
+ // TODO(imcheng): Add Connecting state to Blink (crbug.com/575351).
case presentation::PRESENTATION_CONNECTION_STATE_CONNECTED:
return blink::WebPresentationConnectionState::Connected;
case presentation::PRESENTATION_CONNECTION_STATE_CLOSED:
return blink::WebPresentationConnectionState::Closed;
case presentation::PRESENTATION_CONNECTION_STATE_TERMINATED:
return blink::WebPresentationConnectionState::Terminated;
+ default:
+ NOTREACHED();
+ return blink::WebPresentationConnectionState::Terminated;
}
-
- NOTREACHED();
- return blink::WebPresentationConnectionState::Terminated;
}
} // namespace
« no previous file with comments | « content/public/browser/presentation_session.h ('k') | extensions/renderer/resources/media_router_bindings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698