Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Unified Diff: Source/modules/vibration/Vibration.h

Issue 15724023: Vibration API: use runtime flag, change from client to platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review issues: order vibrate method before cancelVibration, etc. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/vibration/Vibration.h
diff --git a/Source/modules/vibration/Vibration.h b/Source/modules/vibration/Vibration.h
index 1514f15c89b5cea9743fa740080f2698b9add695..cbd22bc4a874e63b11ae0e63916ad85788637aa5 100644
--- a/Source/modules/vibration/Vibration.h
+++ b/Source/modules/vibration/Vibration.h
@@ -20,24 +20,19 @@
#ifndef Vibration_h
#define Vibration_h
-#if ENABLE(VIBRATION)
-
#include "core/page/Page.h"
#include "core/platform/Timer.h"
#include "wtf/PassOwnPtr.h"
namespace WebCore {
-class VibrationClient;
-
class Vibration : public Supplement<Page> {
public:
typedef Vector<unsigned> VibrationPattern;
- explicit Vibration(VibrationClient*);
~Vibration();
- static PassOwnPtr<Vibration> create(VibrationClient*);
+ static PassOwnPtr<Vibration> create();
void vibrate(const unsigned& time);
void vibrate(const VibrationPattern&);
@@ -50,11 +45,11 @@ public:
void timerStopFired(Timer<Vibration>*);
static const char* supplementName();
- static Vibration* from(Page* page) { return static_cast<Vibration*>(Supplement<Page>::from(page, supplementName())); }
+ static Vibration* from(Page*);
static bool isActive(Page*);
private:
- VibrationClient* m_vibrationClient;
+ Vibration();
Peter Beverloo 2013/06/11 13:50:12 nit: newline under this method to visually separat
Michael van Ouwerkerk 2013/06/11 14:16:43 Done.
Timer<Vibration> m_timerStart;
Timer<Vibration> m_timerStop;
bool m_isVibrating;
@@ -63,7 +58,4 @@ private:
} // namespace WebCore
-#endif // ENABLE(VIBRATION)
-
#endif // Vibration_h
-

Powered by Google App Engine
This is Rietveld 408576698