Source/modules/vibration/NavigatorVibration.h - Issue 15724023: Vibration API: use runtime flag, change from client to platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/vibration/NavigatorVibration.h

Issue 15724023: Vibration API: use runtime flag, change from client to platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review issues: order vibrate method before cancelVibration, etc. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/vibration/NavigatorVibration.h

diff --git a/Source/modules/vibration/NavigatorVibration.h b/Source/modules/vibration/NavigatorVibration.h

index aef7c3a512ee978d7c96a730e13207769e53c79f..297ad6d57f36595f1d4e225e0b6ddf69f5eccacd 100644

--- a/Source/modules/vibration/NavigatorVibration.h

+++ b/Source/modules/vibration/NavigatorVibration.h

@@ -20,9 +20,6 @@

#ifndef NavigatorVibration_h

#define NavigatorVibration_h

-#if ENABLE(VIBRATION)

-#include "core/dom/ExceptionCode.h"

#include "wtf/Vector.h"

namespace WebCore {

@@ -34,8 +31,8 @@ class NavigatorVibration {

public:

typedef Vector<unsigned> VibrationPattern;

- static void vibrate(Navigator*, unsigned time, ExceptionCode&);

- static void vibrate(Navigator*, const VibrationPattern&, ExceptionCode&);

+ static void vibrate(Navigator*, unsigned time);

+ static void vibrate(Navigator*, const VibrationPattern&);

private:

NavigatorVibration();

Peter Beverloo 2013/06/11 13:50:12 Do we need the constructor and destructor? They'r

Michael van Ouwerkerk 2013/06/11 14:16:43 Let's just leave a private constructor then.

@@ -44,7 +41,4 @@ private:

} // namespace WebCore

-#endif // ENABLE(VIBRATION)

#endif // NavigatorVibration_h

« no previous file with comments | « Source/modules/modules.gypi ('k') | Source/modules/vibration/NavigatorVibration.cpp » ('j') | Source/modules/vibration/Vibration.h » ('J')