Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1572303002: Subzero. ARM32. Adds header to auto-generated register def file. (Closed)

Created:
4 years, 11 months ago by John
Modified:
4 years, 11 months ago
Reviewers:
Karl, Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : make presubmit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M pydir/gen_arm32_reg_tables.py View 3 chunks +8 lines, -1 line 0 comments Download
M src/IceRegistersARM32.def View 1 5 chunks +10 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
John
4 years, 11 months ago (2016-01-11 14:07:22 UTC) #2
Jim Stichnoth
Thanks! lgtm
4 years, 11 months ago (2016-01-11 14:09:50 UTC) #3
John
Committed patchset #2 (id:20001) manually as d8777b0d1ca05ce4c69b224f04b17b6c0cb5f103 (presubmit successful).
4 years, 11 months ago (2016-01-11 14:11:04 UTC) #5
Jim Stichnoth
4 years, 11 months ago (2016-01-19 21:23:09 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1572303002/diff/20001/src/IceRegistersARM32.def
File src/IceRegistersARM32.def (right):

https://codereview.chromium.org/1572303002/diff/20001/src/IceRegistersARM32.d...
src/IceRegistersARM32.def:8: //define X(AsmStr, CCArg, IsScratch, IsPreserved,
IsStackPtr, IsFramePtr, IsGPR, IsInt, IsI64Pair, IsFP32, IsFP64, IsVec128,
Aliases)
Sorry for the necro comment, but I just noticed that the first two columns of
the table are not described in the comment string.

Powered by Google App Engine
This is Rietveld 408576698