src/flag-definitions.h - Issue 1571873004: Ship ES2015 sloppy-mode const semantics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/flag-definitions.h

Issue 1571873004: Ship ES2015 sloppy-mode const semantics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: More test failures noted Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/flag-definitions.h

diff --git a/src/flag-definitions.h b/src/flag-definitions.h

index 2758f31bf7951fd9d343951da7e54cf59e1d9b1a..9fdd017facc712ab7702b5290fb6297252156913 100644

--- a/src/flag-definitions.h

+++ b/src/flag-definitions.h

@@ -185,9 +185,7 @@ DEFINE_BOOL(harmony, false, "enable all completed harmony features")

DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features")

DEFINE_IMPLICATION(es_staging, harmony)

-DEFINE_BOOL(legacy_const, true, "legacy semantics for const in sloppy mode")

-// ES2015 const semantics are staged

-DEFINE_NEG_IMPLICATION(harmony, legacy_const)

adamk 2016/01/11 18:59:03 I think you want to have DEFINE_NEG_IMPLICATION(ha

Dan Ehrenberg 2016/01/11 21:55:29 Fixed

+DEFINE_BOOL(legacy_const, false, "legacy semantics for const in sloppy mode")

DEFINE_BOOL(promise_extra, true, "additional V8 Promise functions")

// Removing extra Promise functions is staged

« no previous file with comments | « no previous file | test/cctest/compiler/test-run-jsops.cc » ('j') | no next file with comments »