src/flag-definitions.h - Issue 1571873004: Ship ES2015 sloppy-mode const semantics

Side by Side Diff: src/flag-definitions.h

Issue 1571873004: Ship ES2015 sloppy-mode const semantics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: More test failures noted Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | test/cctest/compiler/test-run-jsops.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2012 the V8 project authors. All rights reserved.	1 // Copyright 2012 the V8 project authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // This file defines all of the flags. It is separated into different section,	5 // This file defines all of the flags. It is separated into different section,

6 // for Debug, Release, Logging and Profiling, etc. To add a new flag, find the	6 // for Debug, Release, Logging and Profiling, etc. To add a new flag, find the

7 // correct section, and use one of the DEFINE_ macros, without a trailing ';'.	7 // correct section, and use one of the DEFINE_ macros, without a trailing ';'.

8 //	8 //

9 // This include does not have a guard, because it is a template-style include,	9 // This include does not have a guard, because it is a template-style include,

10 // which can be included multiple times in different modes. It expects to have	10 // which can be included multiple times in different modes. It expects to have

(...skipping 167 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
178 DEFINE_BOOL(strong_mode, false, "experimental strong language mode")	178 DEFINE_BOOL(strong_mode, false, "experimental strong language mode")

179 DEFINE_IMPLICATION(use_strong, strong_mode)	179 DEFINE_IMPLICATION(use_strong, strong_mode)

180 DEFINE_BOOL(strong_this, true, "don't allow 'this' to escape from constructors")	180 DEFINE_BOOL(strong_this, true, "don't allow 'this' to escape from constructors")

181	181

182 DEFINE_BOOL(es_staging, false,	182 DEFINE_BOOL(es_staging, false,

183 "enable test-worthy harmony features (for internal use only)")	183 "enable test-worthy harmony features (for internal use only)")

184 DEFINE_BOOL(harmony, false, "enable all completed harmony features")	184 DEFINE_BOOL(harmony, false, "enable all completed harmony features")

185 DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features")	185 DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features")

186 DEFINE_IMPLICATION(es_staging, harmony)	186 DEFINE_IMPLICATION(es_staging, harmony)

187	187

188 DEFINE_BOOL(legacy_const, true, "legacy semantics for const in sloppy mode")	188 DEFINE_BOOL(legacy_const, false, "legacy semantics for const in sloppy mode")

189 // ES2015 const semantics are staged

190 DEFINE_NEG_IMPLICATION(harmony, legacy_const)
adamk 2016/01/11 18:59:03 I think you want to have DEFINE_NEG_IMPLICATION(ha I think you want to have DEFINE_NEG_IMPLICATION(harmony_shipping, legacy_const) here. That'll cause --noharmony-shipping to re-enable legacy const. Dan Ehrenberg 2016/01/11 21:55:29 Fixed Show quoted text On 2016/01/11 at 18:59:03, adamk wrote: > I think you want to have DEFINE_NEG_IMPLICATION(harmony_shipping, legacy_const) here. That'll cause --noharmony-shipping to re-enable legacy const. Fixed
191	189

192 DEFINE_BOOL(promise_extra, true, "additional V8 Promise functions")	190 DEFINE_BOOL(promise_extra, true, "additional V8 Promise functions")

193 // Removing extra Promise functions is staged	191 // Removing extra Promise functions is staged

194 DEFINE_NEG_IMPLICATION(harmony, promise_extra)	192 DEFINE_NEG_IMPLICATION(harmony, promise_extra)

195	193

196 // Activate on ClusterFuzz.	194 // Activate on ClusterFuzz.

197 DEFINE_IMPLICATION(es_staging, harmony_regexp_lookbehind)	195 DEFINE_IMPLICATION(es_staging, harmony_regexp_lookbehind)

198 DEFINE_IMPLICATION(es_staging, move_object_start)	196 DEFINE_IMPLICATION(es_staging, move_object_start)

199	197

200 // Features that are still work in progress (behind individual flags).	198 // Features that are still work in progress (behind individual flags).

(...skipping 934 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1135 #undef DEFINE_ALIAS_FLOAT	1133 #undef DEFINE_ALIAS_FLOAT

1136 #undef DEFINE_ALIAS_ARGS	1134 #undef DEFINE_ALIAS_ARGS

1137	1135

1138 #undef FLAG_MODE_DECLARE	1136 #undef FLAG_MODE_DECLARE

1139 #undef FLAG_MODE_DEFINE	1137 #undef FLAG_MODE_DEFINE

1140 #undef FLAG_MODE_DEFINE_DEFAULTS	1138 #undef FLAG_MODE_DEFINE_DEFAULTS

1141 #undef FLAG_MODE_META	1139 #undef FLAG_MODE_META

1142 #undef FLAG_MODE_DEFINE_IMPLICATIONS	1140 #undef FLAG_MODE_DEFINE_IMPLICATIONS

1143	1141

1144 #undef COMMA	1142 #undef COMMA

OLD	NEW