Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1571873004: Ship ES2015 sloppy-mode const semantics (Closed)

Created:
4 years, 11 months ago by Dan Ehrenberg
Modified:
4 years, 11 months ago
Reviewers:
adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship ES2015 sloppy-mode const semantics This patch moves the semantics of 'const' in sloppy mode to match those in strict mode, that is, const makes lexical (let-like) bindings, must have an initializer, and does not create properties of the global object. R=adamk LOG=Y BUG=v8:3305 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/95145fa82612dda7cee08e2ffee4b4316cb328e1 Cr-Commit-Position: refs/heads/master@{#33218}

Patch Set 1 #

Patch Set 2 : More test failures noted #

Total comments: 2

Patch Set 3 : Associate with --harmony-shipping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -35 lines) Patch
M src/flag-definitions.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-jsops.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-run-variables.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-decls.cc View 1 6 chunks +6 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M test/mjsunit/compiler/regress-96989.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/regress-const.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/const.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/const-declaration.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/const-eval-init.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/const-redecl.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/constant-folding.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/debug-evaluate-const.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/declare-locally.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/block-eval-var-over-legacy-const.js View 3 chunks +5 lines, -3 lines 0 comments Download
M test/mjsunit/es6/block-let-contextual-sloppy.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/global-const-var-conflicts.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/parallel-optimize-disabled.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/property-load-across-eval.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-1178598.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-1182832.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-1199637.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1201933.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-1207276.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-1213575.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-186.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-3138.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-436896.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-641.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-799761.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-88591.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-debugger-redirect.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-handle-illegal-redeclaration.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mozilla/mozilla.status View 1 2 chunks +11 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M test/webkit/const-without-initializer.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/webkit/constant-count.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/webkit/fast/js/arguments-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/function-toString-parentheses-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/fast/js/parser-syntax-check-expected.txt View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571873004/1
4 years, 11 months ago (2016-01-08 22:57:35 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/13883)
4 years, 11 months ago (2016-01-08 23:11:14 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571873004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571873004/20001
4 years, 11 months ago (2016-01-09 03:23:00 UTC) #6
Dan Ehrenberg
4 years, 11 months ago (2016-01-09 03:23:05 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/81297)
4 years, 11 months ago (2016-01-09 05:06:21 UTC) #9
adamk
https://codereview.chromium.org/1571873004/diff/20001/src/flag-definitions.h File src/flag-definitions.h (left): https://codereview.chromium.org/1571873004/diff/20001/src/flag-definitions.h#oldcode190 src/flag-definitions.h:190: DEFINE_NEG_IMPLICATION(harmony, legacy_const) I think you want to have DEFINE_NEG_IMPLICATION(harmony_shipping, ...
4 years, 11 months ago (2016-01-11 18:59:03 UTC) #10
Dan Ehrenberg
https://codereview.chromium.org/1571873004/diff/20001/src/flag-definitions.h File src/flag-definitions.h (left): https://codereview.chromium.org/1571873004/diff/20001/src/flag-definitions.h#oldcode190 src/flag-definitions.h:190: DEFINE_NEG_IMPLICATION(harmony, legacy_const) On 2016/01/11 at 18:59:03, adamk wrote: > ...
4 years, 11 months ago (2016-01-11 21:55:29 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571873004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571873004/60001
4 years, 11 months ago (2016-01-11 21:55:47 UTC) #13
adamk
lgtm
4 years, 11 months ago (2016-01-11 22:06:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571873004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571873004/40001
4 years, 11 months ago (2016-01-11 22:06:29 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-11 23:09:31 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 23:10:09 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95145fa82612dda7cee08e2ffee4b4316cb328e1
Cr-Commit-Position: refs/heads/master@{#33218}

Powered by Google App Engine
This is Rietveld 408576698