Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1571753002: [Interpreter] Loads accumulator before calling StoreNamedProperty in ForInAssignment. (Closed)

Created:
4 years, 11 months ago by mythria
Modified:
4 years, 11 months ago
Reviewers:
oth, rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Loads accumulator before calling StoreNamedProperty in ForInAssignment. Fixed a bug in VisitForInAssignment. After visiting the object the value to be stored was not loaded back to the accumulator. Also added two tests to check this case. BUG=v8:4280 LOG=N Committed: https://crrev.com/3f0b6c5dcce10becbd615c373434043afc7ec190 Cr-Commit-Position: refs/heads/master@{#33188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +21 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
mythria
PTAL, Thanks, Mythri
4 years, 11 months ago (2016-01-08 14:53:49 UTC) #2
oth
LGTM. Thanks for fixing this and the test.
4 years, 11 months ago (2016-01-08 14:58:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571753002/1
4 years, 11 months ago (2016-01-08 15:15:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9566)
4 years, 11 months ago (2016-01-08 15:42:48 UTC) #7
mythria
Ross, could you please take a look. Thanks, Mythri
4 years, 11 months ago (2016-01-08 15:50:42 UTC) #9
rmcilroy
LGTM, thanks for fixing
4 years, 11 months ago (2016-01-08 16:04:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571753002/1
4 years, 11 months ago (2016-01-08 17:00:42 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 17:02:02 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 17:02:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f0b6c5dcce10becbd615c373434043afc7ec190
Cr-Commit-Position: refs/heads/master@{#33188}

Powered by Google App Engine
This is Rietveld 408576698