Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: src/interpreter/bytecode-generator.cc

Issue 1571753002: [Interpreter] Loads accumulator before calling StoreNamedProperty in ForInAssignment. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/cctest/interpreter/test-interpreter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/bytecode-generator.h" 5 #include "src/interpreter/bytecode-generator.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/compiler.h" 8 #include "src/compiler.h"
9 #include "src/interpreter/control-flow-builders.h" 9 #include "src/interpreter/control-flow-builders.h"
10 #include "src/objects.h" 10 #include "src/objects.h"
(...skipping 833 matching lines...) Expand 10 before | Expand all | Expand 10 after
844 Variable* variable = expr->AsVariableProxy()->var(); 844 Variable* variable = expr->AsVariableProxy()->var();
845 VisitVariableAssignment(variable, slot); 845 VisitVariableAssignment(variable, slot);
846 break; 846 break;
847 } 847 }
848 case NAMED_PROPERTY: { 848 case NAMED_PROPERTY: {
849 TemporaryRegisterScope temporary_register_scope(builder()); 849 TemporaryRegisterScope temporary_register_scope(builder());
850 Register value = temporary_register_scope.NewRegister(); 850 Register value = temporary_register_scope.NewRegister();
851 builder()->StoreAccumulatorInRegister(value); 851 builder()->StoreAccumulatorInRegister(value);
852 Register object = VisitForRegisterValue(property->obj()); 852 Register object = VisitForRegisterValue(property->obj());
853 Handle<String> name = property->key()->AsLiteral()->AsPropertyName(); 853 Handle<String> name = property->key()->AsLiteral()->AsPropertyName();
854 builder()->LoadAccumulatorWithRegister(value);
854 builder()->StoreNamedProperty(object, name, feedback_index(slot), 855 builder()->StoreNamedProperty(object, name, feedback_index(slot),
855 language_mode()); 856 language_mode());
856 break; 857 break;
857 } 858 }
858 case KEYED_PROPERTY: { 859 case KEYED_PROPERTY: {
859 TemporaryRegisterScope temporary_register_scope(builder()); 860 TemporaryRegisterScope temporary_register_scope(builder());
860 Register value = temporary_register_scope.NewRegister(); 861 Register value = temporary_register_scope.NewRegister();
861 builder()->StoreAccumulatorInRegister(value); 862 builder()->StoreAccumulatorInRegister(value);
862 Register object = VisitForRegisterValue(property->obj()); 863 Register object = VisitForRegisterValue(property->obj());
863 Register key = VisitForRegisterValue(property->key()); 864 Register key = VisitForRegisterValue(property->key());
(...skipping 1363 matching lines...) Expand 10 before | Expand all | Expand 10 after
2227 } 2228 }
2228 2229
2229 2230
2230 int BytecodeGenerator::feedback_index(FeedbackVectorSlot slot) const { 2231 int BytecodeGenerator::feedback_index(FeedbackVectorSlot slot) const {
2231 return info()->feedback_vector()->GetIndex(slot); 2232 return info()->feedback_vector()->GetIndex(slot);
2232 } 2233 }
2233 2234
2234 } // namespace interpreter 2235 } // namespace interpreter
2235 } // namespace internal 2236 } // namespace internal
2236 } // namespace v8 2237 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/cctest/interpreter/test-interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698