Chromium Code Reviews| Index: src/IceRegistersARM32.h |
| diff --git a/src/IceRegistersARM32.h b/src/IceRegistersARM32.h |
| index 31323c250b9d725410133ec4e9094ba2d8512233..7a350597a417a26cb7e1a20012fcbe8a6fa96572 100644 |
| --- a/src/IceRegistersARM32.h |
| +++ b/src/IceRegistersARM32.h |
| @@ -49,6 +49,7 @@ private: |
| const std::size_t Size; |
| }; |
| +// TODO(kschimpf) Change this class to a namespace. |
|
Jim Stichnoth
2016/01/14 22:04:19
I think you should just revert this file entirely,
Karl
2016/01/14 23:54:51
Reverted.
|
| class RegARM32 { |
| private: |
| RegARM32() = delete; |
| @@ -146,13 +147,13 @@ public: |
| #undef X |
| }; |
| - static inline void assertRegisterDefined(int32_t RegNum) { |
| + static void assertRegisterDefined(int32_t RegNum) { |
| (void)RegNum; |
| assert(RegNum >= 0); |
| assert(RegNum < Reg_NUM); |
| } |
| - static inline bool isGPRegister(int32_t RegNum) { |
| + static bool isGPRegister(int32_t RegNum) { |
| assertRegisterDefined(RegNum); |
| return Table[RegNum].IsGPR; |
| } |
| @@ -167,7 +168,7 @@ public: |
| ; |
| } |
| - static inline GPRRegister getEncodedGPR(int32_t RegNum) { |
| + static GPRRegister getEncodedGPR(int32_t RegNum) { |
| assert(isGPRegister(RegNum)); |
| return GPRRegister(Table[RegNum].Encoding); |
| } |
| @@ -182,32 +183,32 @@ public: |
| ; |
| } |
| - static inline bool isGPR(SizeT RegNum) { |
| + static bool isGPR(SizeT RegNum) { |
| assertRegisterDefined(RegNum); |
| return Table[RegNum].IsGPR; |
| } |
| - static inline IceString getGPRName(SizeT RegNum) { |
| + static IceString getGPRName(SizeT RegNum) { |
|
Jim Stichnoth
2016/01/14 22:04:19
This would more accurately be named getRegName(),
Karl
2016/01/14 23:54:51
Acknowledged.
|
| assert(isGPR(RegNum)); |
| return Table[RegNum].Name; |
| } |
| - static inline GPRRegister getI64PairFirstGPRNum(int32_t RegNum) { |
| + static GPRRegister getI64PairFirstGPRNum(int32_t RegNum) { |
| assert(isI64RegisterPair(RegNum)); |
| return GPRRegister(Table[RegNum].Encoding); |
| } |
| - static inline GPRRegister getI64PairSecondGPRNum(int32_t RegNum) { |
| + static GPRRegister getI64PairSecondGPRNum(int32_t RegNum) { |
| assert(isI64RegisterPair(RegNum)); |
| return GPRRegister(Table[RegNum].Encoding + 1); |
| } |
| - static inline bool isI64RegisterPair(int32_t RegNum) { |
| + static bool isI64RegisterPair(int32_t RegNum) { |
| assertRegisterDefined(RegNum); |
| return Table[RegNum].IsI64Pair; |
| } |
| - static inline bool isEncodedSReg(int32_t RegNum) { |
| + static bool isEncodedSReg(int32_t RegNum) { |
| assertRegisterDefined(RegNum); |
| return Table[RegNum].IsFP32; |
| } |
| @@ -222,22 +223,22 @@ public: |
| ; |
| } |
| - static inline IceString getSRegName(SizeT RegNum) { |
| + static IceString getSRegName(SizeT RegNum) { |
| assert(isEncodedSReg(RegNum)); |
| return Table[RegNum].Name; |
| } |
| - static inline SRegister getEncodedSReg(int32_t RegNum) { |
| + static SRegister getEncodedSReg(int32_t RegNum) { |
| assert(isEncodedSReg(RegNum)); |
| return SRegister(Table[RegNum].Encoding); |
| } |
| - static inline bool isEncodedDReg(int32_t RegNum) { |
| + static bool isEncodedDReg(int32_t RegNum) { |
| assertRegisterDefined(RegNum); |
| return Table[RegNum].IsFP64; |
| } |
| - static constexpr inline SizeT getNumDRegs() { |
| + static constexpr SizeT getNumDRegs() { |
| return 0 |
| #define X(val, encode, name, cc_arg, scratch, preserved, stackptr, frameptr, \ |
| isGPR, isInt, isI64Pair, isFP32, isFP64, isVec128, alias_init) \ |
| @@ -247,22 +248,22 @@ public: |
| ; |
| } |
| - static inline DRegister getEncodedDReg(int32_t RegNum) { |
| + static DRegister getEncodedDReg(int32_t RegNum) { |
| assert(isEncodedDReg(RegNum)); |
| return DRegister(Table[RegNum].Encoding); |
| } |
| - static inline bool isEncodedQReg(int32_t RegNum) { |
| + static bool isEncodedQReg(int32_t RegNum) { |
| assertRegisterDefined(RegNum); |
| return Table[RegNum].IsVec128; |
| } |
| - static inline QRegister getEncodedQReg(int32_t RegNum) { |
| + static QRegister getEncodedQReg(int32_t RegNum) { |
| assert(isEncodedQReg(RegNum)); |
| return QRegister(Table[RegNum].Encoding); |
| } |
| - static inline IceString getRegName(int32_t RegNum) { |
| + static IceString getRegName(int32_t RegNum) { |
| assertRegisterDefined(RegNum); |
| return Table[RegNum].Name; |
| } |