Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1571343002: [Merge M48] Remove support for chrome_shortcut_icon_index master_pref. (Closed)

Created:
4 years, 11 months ago by gab
Modified:
4 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

[Merge M48] Remove support for chrome_shortcut_icon_index master_pref. Old icons were removed in M47 and there is thus no reason to support using an alternate icon index anymore. BUG=570366 Review URL: https://codereview.chromium.org/1543853002 Cr-Commit-Position: refs/heads/master@{#368086} (cherry picked from commit 0e35f1c49a0f195c0579e5a2867ce01d0f78393e) Conflicts: chrome/installer/util/master_preferences.h chrome/installer/util/master_preferences_unittest.cc TBR=mgiuca@chromium.org, grt@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/33cbe8cd1085e155ab08aa68e55e78a602cd625f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -33 lines) Patch
M chrome/installer/util/chrome_browser_operations.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M chrome/installer/util/master_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/master_preferences_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 4 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
gab
FYI/TBR mgiuca/grt: merging this to M48.
4 years, 11 months ago (2016-01-11 15:22:14 UTC) #3
gab
4 years, 11 months ago (2016-01-11 15:37:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
33cbe8cd1085e155ab08aa68e55e78a602cd625f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698