Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1543853002: Remove support for chrome_shortcut_icon_index master_pref. (Closed)

Created:
5 years ago by gab
Modified:
4 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for chrome_shortcut_icon_index master_pref. Old icons were removed in M47 and there is thus no reason to support using an alternate icon index anymore. BUG=570366 Committed: https://crrev.com/0e35f1c49a0f195c0579e5a2867ce01d0f78393e Cr-Commit-Position: refs/heads/master@{#368086}

Patch Set 1 #

Patch Set 2 : fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -33 lines) Patch
M chrome/installer/util/chrome_browser_operations.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M chrome/installer/util/master_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/master_preferences_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 1 4 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
gab
PTAL, simple removal :-) Thanks, Gab
5 years ago (2015-12-22 16:50:05 UTC) #2
gab
Matt can you PTAL in grt's absence?
4 years, 11 months ago (2016-01-04 14:05:03 UTC) #4
Matt Giuca
lgtm
4 years, 11 months ago (2016-01-05 06:39:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543853002/1
4 years, 11 months ago (2016-01-05 14:46:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/150043)
4 years, 11 months ago (2016-01-05 16:05:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543853002/20001
4 years, 11 months ago (2016-01-07 15:29:53 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-07 16:12:43 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 16:14:01 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e35f1c49a0f195c0579e5a2867ce01d0f78393e
Cr-Commit-Position: refs/heads/master@{#368086}

Powered by Google App Engine
This is Rietveld 408576698