Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 15713015: Read and write pixel offset when serializing bitmaps. (Closed)

Created:
7 years, 6 months ago by scroggo
Modified:
7 years, 6 months ago
Reviewers:
djsollen, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Read and write pixel offset when serializing bitmaps. Remove ifdef's preventing a change to read and write offsets. This fixes a bug where the SKP will draw the wrong portion of bitmaps. In addition, read the offset from the stream whether the bitmap decoder succeeds or not, so that a failure to decode still advances the stream to the correct spot. Set the offset to 0 before calling SkPicture::EncodeBitmap, so that if the function does not set it, we will not modify the offset. REQUIRES A CHANGE TO THE PICTURE VERSION. Does not change PICTURE_VERSION itself, since other CLs are also requiring a change. BUG=https://code.google.com/p/skia/issues/detail?id=1301 R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=9368

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M src/core/SkOrderedReadBuffer.cpp View 2 chunks +7 lines, -10 lines 0 comments Download
M src/core/SkOrderedWriteBuffer.cpp View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
part of the picture pile on
7 years, 6 months ago (2013-05-30 19:58:39 UTC) #1
djsollen
lgtm
7 years, 6 months ago (2013-05-30 20:23:23 UTC) #2
scroggo
7 years, 6 months ago (2013-05-31 14:39:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r9368.

Powered by Google App Engine
This is Rietveld 408576698