third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp - Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp

Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improved ALLOW_NUMERIC_ARG_TYPES_PROMOTABLE_TO Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.h ('k') | third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp b/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp

index a64f4d7691a8e96f8e6cb33339d77d7b533a2576..63a380a34bced9cbb5bace6ab5820c07a60df9b1 100644

--- a/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp

@@ -88,7 +88,7 @@ size_t FastSharedBufferReader::getSomeData(const char*& someData, size_t dataPos

return m_segmentLength;

}

-void FastSharedBufferReader::getSomeDataInternal(unsigned dataPosition) const

+void FastSharedBufferReader::getSomeDataInternal(size_t dataPosition) const

{

m_dataPosition = dataPosition;

m_segmentLength = m_data->getSomeData(m_segment, dataPosition);