third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp - Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp

Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improved ALLOW_NUMERIC_ARG_TYPES_PROMOTABLE_TO Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.h ('k') | third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2015 Google Inc. All rights reserved.	2 * Copyright (C) 2015 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 70 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
81 }	81 }

82 }	82 }

83	83

84 size_t FastSharedBufferReader::getSomeData(const char*& someData, size_t dataPos ition) const	84 size_t FastSharedBufferReader::getSomeData(const char*& someData, size_t dataPos ition) const

85 {	85 {

86 getSomeDataInternal(dataPosition);	86 getSomeDataInternal(dataPosition);

87 someData = m_segment;	87 someData = m_segment;

88 return m_segmentLength;	88 return m_segmentLength;

89 }	89 }

90	90

91 void FastSharedBufferReader::getSomeDataInternal(unsigned dataPosition) const	91 void FastSharedBufferReader::getSomeDataInternal(size_t dataPosition) const

92 {	92 {

93 m_dataPosition = dataPosition;	93 m_dataPosition = dataPosition;

94 m_segmentLength = m_data->getSomeData(m_segment, dataPosition);	94 m_segmentLength = m_data->getSomeData(m_segment, dataPosition);

95 ASSERT(m_segmentLength);	95 ASSERT(m_segmentLength);

96 }	96 }

97	97

98 } // namespace blink	98 } // namespace blink

OLD	NEW