Issue 15709012: Revert 205329 "Split pnacl and nacl mime types"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15709012: Revert 205329 "Split pnacl and nacl mime types" (Closed)

Created:
7 years, 6 months ago by garykac

Modified:
7 years, 6 months ago

Reviewers:
sehr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 205329 "Split pnacl and nacl mime types" NaCl integration tests fail: run_ppapi_bad_browser_test (scons-out/nacl-x86-64/test_results/ppapi_bad_browser_test.out) failed: Source `tests/ppapi_browser/bad/ppapi_bad_doesnotexist_nexe_only.nmf' not found, needed by target `scons-out/nacl-x86-64/test_results/ppapi_bad_browser_test.out'. > Split pnacl and nacl mime types > > Manifest parsing now knows which mime type was used, and does not allow > pnacl to be used from nacl manifests or vice-versa. > > BUG= https://code.google.com/p/nativeclient/issues/detail?id=3440 > R=bradnelson@chromium.org, jam@chromium.org, jvoung@chromium.org > > Review URL: https://codereview.chromium.org/16296005 TBR=sehr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205340

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+181 lines, -459 lines)			Patch
M	trunk/src/chrome/common/chrome_content_client.cc	View	3 chunks	+5 lines, -19 lines	0 comments	Download
M	trunk/src/chrome/renderer/chrome_content_renderer_client.cc	View	2 chunks	+39 lines, -59 lines	0 comments	Download
M	trunk/src/chrome/test/data/nacl/exit_status/pm_exit_status_test.html	View	1 chunk	+10 lines, -19 lines	0 comments	Download
M	trunk/src/chrome/test/data/nacl/nacl_load_test.html	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/test/data/nacl/nacl_test_data.gyp	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	trunk/src/chrome/test/data/nacl/pnacl_dyncode_syscall_disabled/pnacl_dyncode_syscall_disabled.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/test/data/nacl/pnacl_error_handling/pnacl_error_handling.html	View	4 chunks	+0 lines, -4 lines	0 comments	Download
D	trunk/src/chrome/test/data/nacl/pnacl_mime_type/pnacl_mime_type.html	View	1 chunk	+0 lines, -56 lines	0 comments	Download
M	trunk/src/chrome/test/data/nacl/pnacl_nmf_options/pnacl_options.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/test/data/nacl/ppapi/ppb_core/ppapi_ppb_core.html	View	1 chunk	+5 lines, -17 lines	0 comments	Download
M	trunk/src/chrome/test/data/nacl/progress_events/ppapi_progress_events.html	View	1 chunk	+5 lines, -17 lines	0 comments	Download
M	trunk/src/chrome/test/nacl/nacl_browsertest.cc	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/test/nacl/nacl_browsertest_util.cc	View	3 chunks	+2 lines, -19 lines	0 comments	Download
M	trunk/src/ppapi/native_client/src/trusted/plugin/json_manifest.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	trunk/src/ppapi/native_client/src/trusted/plugin/json_manifest.cc	View	19 chunks	+55 lines, -168 lines	0 comments	Download
M	trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/ppapi/native_client/src/trusted/plugin/plugin.cc	View	4 chunks	+5 lines, -7 lines	0 comments	Download
M	trunk/src/ppapi/native_client/tests/nacl_browser/manifest_file/irt_manifest_file.nmf	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	trunk/src/ppapi/native_client/tests/nacl_browser/manifest_file/pm_manifest_file.nmf	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	trunk/src/ppapi/native_client/tests/nacl_browser/manifest_file/pm_pre_init_manifest_file.nmf	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	trunk/src/ppapi/native_client/tests/ppapi_browser/bad/ppapi_bad.html	View	14 chunks	+11 lines, -22 lines	0 comments	Download
M	trunk/src/ppapi/native_client/tests/ppapi_browser/bad/ppapi_bad.js	View	2 chunks	+4 lines, -9 lines	0 comments	Download
M	trunk/src/ppapi/native_client/tests/ppapi_browser/bad/ppapi_bad_crossorigin.nmf	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	trunk/src/ppapi/native_client/tests/ppapi_browser/bad/ppapi_bad_doesnotexist.nmf	View	1 chunk	+2 lines, -1 line	0 comments	Download
A +	trunk/src/ppapi/native_client/tests/ppapi_browser/bad/ppapi_bad_doesnotexist_nexe_only.nmf	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/ppapi/native_client/tests/ppapi_browser/manifest/manifest_arch_specific.nmf	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	trunk/src/ppapi/native_client/tests/ppapi_browser/manifest/manifest_subdir.nmf	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	trunk/src/ppapi/native_client/tests/ppapi_browser/manifest/manifest_top.nmf	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r205340.

Expand Messages | Collapse Messages