Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: trunk/src/chrome/test/nacl/nacl_browsertest_util.cc

Issue 15709012: Revert 205329 "Split pnacl and nacl mime types" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/test/nacl/nacl_browsertest_util.cc
===================================================================
--- trunk/src/chrome/test/nacl/nacl_browsertest_util.cc (revision 205338)
+++ trunk/src/chrome/test/nacl/nacl_browsertest_util.cc (working copy)
@@ -177,15 +177,6 @@
return true;
}
-static void AddPnaclParm(const base::FilePath::StringType& url,
- base::FilePath::StringType* url_with_parm) {
- if (url.find(FILE_PATH_LITERAL("?")) == base::FilePath::StringType::npos) {
- *url_with_parm = url + FILE_PATH_LITERAL("?pnacl=1");
- } else {
- *url_with_parm = url + FILE_PATH_LITERAL("&pnacl=1");
- }
-}
-
NaClBrowserTestBase::NaClBrowserTestBase() {
}
@@ -233,11 +224,7 @@
void NaClBrowserTestBase::RunLoadTest(
const base::FilePath::StringType& test_file) {
LoadTestMessageHandler handler;
- base::FilePath::StringType test_file_with_parm = test_file;
- if (IsPnacl()) {
- AddPnaclParm(test_file, &test_file_with_parm);
- }
- bool ok = RunJavascriptTest(TestURL(test_file_with_parm), &handler);
+ bool ok = RunJavascriptTest(TestURL(test_file), &handler);
ASSERT_TRUE(ok) << handler.error_message();
ASSERT_TRUE(handler.test_passed()) << "Test failed.";
}
@@ -245,11 +232,7 @@
void NaClBrowserTestBase::RunNaClIntegrationTest(
const base::FilePath::StringType& url_fragment) {
NaClIntegrationMessageHandler handler;
- base::FilePath::StringType url_fragment_with_parm = url_fragment;
- if (IsPnacl()) {
- AddPnaclParm(url_fragment, &url_fragment_with_parm);
- }
- bool ok = RunJavascriptTest(TestURL(url_fragment_with_parm), &handler);
+ bool ok = RunJavascriptTest(TestURL(url_fragment), &handler);
ASSERT_TRUE(ok) << handler.error_message();
ASSERT_TRUE(handler.test_passed()) << "Test failed.";
}
« no previous file with comments | « trunk/src/chrome/test/nacl/nacl_browsertest.cc ('k') | trunk/src/ppapi/native_client/src/trusted/plugin/json_manifest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698