Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1570893003: Clean compiling warnings on Linux (Closed)

Created:
4 years, 11 months ago by jun_fang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com, kai_jing
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -49 lines) Patch
M xfa/src/fdp/src/css/fde_cssstyleselector.cpp View 1 chunk +0 lines, -4 lines 2 comments Download
M xfa/src/fxbarcode/BC_BarCode.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M xfa/src/fxbarcode/BC_TwoDimWriter.h View 1 chunk +0 lines, -22 lines 0 comments Download
M xfa/src/fxbarcode/BC_Writer.h View 1 chunk +0 lines, -11 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedUPCAWriter.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jun_fang
https://codereview.chromium.org/1570893003/diff/1/xfa/src/fdp/src/css/fde_cssstyleselector.cpp File xfa/src/fdp/src/css/fde_cssstyleselector.cpp (left): https://codereview.chromium.org/1570893003/diff/1/xfa/src/fdp/src/css/fde_cssstyleselector.cpp#oldcode602 xfa/src/fdp/src/css/fde_cssstyleselector.cpp:602: pComputedStyle = pComputedStyle; // FIXME: likely a real bug. ...
4 years, 11 months ago (2016-01-09 07:01:47 UTC) #3
Tom Sepez
lgtm https://codereview.chromium.org/1570893003/diff/1/xfa/src/fdp/src/css/fde_cssstyleselector.cpp File xfa/src/fdp/src/css/fde_cssstyleselector.cpp (left): https://codereview.chromium.org/1570893003/diff/1/xfa/src/fdp/src/css/fde_cssstyleselector.cpp#oldcode602 xfa/src/fdp/src/css/fde_cssstyleselector.cpp:602: pComputedStyle = pComputedStyle; // FIXME: likely a real ...
4 years, 11 months ago (2016-01-11 17:21:01 UTC) #4
jun_fang
4 years, 11 months ago (2016-01-12 03:01:12 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
65ac873de9164c01af2579a773344c4bca7254d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698