xfa/src/fdp/src/css/fde_cssstyleselector.cpp - Issue 1570893003: Clean compiling warnings on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fdp/src/css/fde_cssstyleselector.cpp

Issue 1570893003: Clean compiling warnings on Linux (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fdp/src/css/fde_cssstyleselector.cpp

diff --git a/xfa/src/fdp/src/css/fde_cssstyleselector.cpp b/xfa/src/fdp/src/css/fde_cssstyleselector.cpp

index 6600449aa55bbe8f48fe4e68c452e0b2bcf65006..2909a750c76d14a59b243ec6784da5a8dfa12984 100644

--- a/xfa/src/fdp/src/css/fde_cssstyleselector.cpp

+++ b/xfa/src/fdp/src/css/fde_cssstyleselector.cpp

@@ -597,10 +597,6 @@ void CFDE_CSSStyleSelector::ApplyProperty(

FDE_CSSPROPERTY eProperty,

IFDE_CSSValue* pValue,

CFDE_CSSComputedStyle* pComputedStyle) {

- if (pComputedStyle->m_InheritedData.m_pFontFamily &&

- *(FX_DWORD*)pComputedStyle->m_InheritedData.m_pFontFamily == 0xcdcdcdcd) {

- pComputedStyle = pComputedStyle; // FIXME: likely a real bug.

jun_fang 2016/01/09 07:01:46 It seems that this sentence was used to set a brea

Tom Sepez 2016/01/11 17:21:00 Acknowledged.

- }

if (pValue->GetType() == FDE_CSSVALUETYPE_Primitive) {

IFDE_CSSPrimitiveValue* pPrimitive = (IFDE_CSSPrimitiveValue*)pValue;

FDE_CSSPRIMITIVETYPE eType = pPrimitive->GetPrimitiveType();

« no previous file with comments | « no previous file | xfa/src/fxbarcode/BC_BarCode.cpp » ('j') | no next file with comments »