core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp - Issue 1570873005: Tidy up shading patterns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

Issue 1570873005: Tidy up shading patterns (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: || Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

index d0cf9ed719fe36561f7391903fd8a67371cb7fa2..affc0dc5262d4e70c41556cb0ebeb97e9e01a6dd 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

@@ -1102,10 +1102,10 @@ void CPDF_StreamContentParser::Handle_ShadeFill() {

if (!pPattern) {

return;

}

- if (pPattern->m_PatternType != PATTERN_SHADING) {

+ if (pPattern->m_PatternType != CPDF_Pattern::SHADING) {

return;

}

- CPDF_ShadingPattern* pShading = (CPDF_ShadingPattern*)pPattern;

+ CPDF_ShadingPattern* pShading = static_cast<CPDF_ShadingPattern*>(pPattern);

if (!pShading->m_bShadingObj) {

return;

}