Issue 1570813003: dart2js cps: Fix for tear-off of noSuchMethod or toString on null.

Issue 1570813003: dart2js cps: Fix for tear-off of noSuchMethod or toString on null. (Closed)

Created:
4 years, 11 months ago by asgerf

Modified:
4 years, 11 months ago

Reviewers:
Kevin Millikin (Google), sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Fix for tear-off of noSuchMethod or toString on null. Some optimizations would assume that null.toString and null.noSuchMethod would throw because these selectors were not whitelisted as non-throwing. BUG= Committed: https://github.com/dart-lang/sdk/commit/8eb030b41927501c487b492dd0a817484af59f87

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	pkg/compiler/lib/src/common/names.dart	View	1	2 chunks	+11 lines, -2 lines	0 comments	Download
	M	pkg/compiler/lib/src/cps_ir/optimizers.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 9 (4 generated)

asgerf

Committed patchset #2 (id:20001) manually as 8eb030b41927501c487b492dd0a817484af59f87 (presubmit successful).

4 years, 11 months ago (2016-01-08 20:50:07 UTC) #8

Message was sent while issue was closed.

lgtm