Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: pkg/compiler/lib/src/cps_ir/optimizers.dart

Issue 1570813003: dart2js cps: Fix for tear-off of noSuchMethod or toString on null. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/common/names.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/optimizers.dart
diff --git a/pkg/compiler/lib/src/cps_ir/optimizers.dart b/pkg/compiler/lib/src/cps_ir/optimizers.dart
index 45606ecc86557be7f1080835c501c9c68ed678ab..19227ad6c51b2b4d287aaaf9e6d2dc6bc3d064e9 100644
--- a/pkg/compiler/lib/src/cps_ir/optimizers.dart
+++ b/pkg/compiler/lib/src/cps_ir/optimizers.dart
@@ -54,7 +54,8 @@ bool isTruthyConstant(ConstantValue value, {bool strict: false}) {
return strict ? value.isTrue : !isFalsyConstant(value);
}
-/// Selector that do not throw when invoked on the null class.
+/// Selectors that do not throw when invoked on the null value.
final List<Selector> selectorsOnNull = <Selector>[
Selectors.equals, Selectors.hashCode_, Selectors.runtimeType_,
- Selectors.toString_];
+ Selectors.toString_, Selectors.toStringGetter,
+ Selectors.noSuchMethodGetter];
« no previous file with comments | « pkg/compiler/lib/src/common/names.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698