Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5306)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h

Issue 1570783003: [Autofill] Move functions from the AutofillPopupController to AutofillPopupLayoutModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: size_t -> int Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h
index 314a6ab8753e7b7e867d5979d639b518cfb1befb..55c9e3a79c3c0c1fb33c302f95430f52277a72e8 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h
+++ b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h
@@ -22,13 +22,29 @@ namespace autofill {
class AutofillPopupViewDelegate;
+class AutofillPopupViewCocoaDelegate {
+ public:
+ // Returns the bounds of the item at |index| in the popup, relative to
+ // the top left of the popup.
+ virtual gfx::Rect GetRowBounds(size_t index) = 0;
+
+ // Gets the resource value for the given resource, returning -1 if the
+ // resource isn't recognized.
+ virtual int GetIconResourceID(const base::string16& resource_name) = 0;
+};
+
// Mac implementation of the AutofillPopupView interface.
// Serves as a bridge to an instance of the Objective-C class which actually
// implements the view.
-class AutofillPopupViewBridge : public AutofillPopupView {
+class AutofillPopupViewBridge : public AutofillPopupView,
+ public AutofillPopupViewCocoaDelegate {
public:
explicit AutofillPopupViewBridge(AutofillPopupController* controller);
+ // AutofillPopupViewBridgeDelegate implementation.
Ilya Sherman 2016/01/20 23:25:18 nit: "AutofillPopupViewCocoaDelegate:"?
Mathieu 2016/01/21 01:25:08 Done.
+ gfx::Rect GetRowBounds(size_t index) override;
+ int GetIconResourceID(const base::string16& resource_name) override;
+
private:
~AutofillPopupViewBridge() override;

Powered by Google App Engine
This is Rietveld 408576698